Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POLIO-1751 embedded pdf translations #1821

Merged
merged 6 commits into from
Nov 25, 2024

Conversation

quang-le
Copy link
Member

@quang-le quang-le commented Nov 22, 2024

What problem is this PR solving? Explain here in one sentence.

Related JIRA tickets : POLIO-1751

Self proofreading checklist

  • Did I use eslint and black formatters
  • Is my code clear enough and well documented
  • Are my typescript files well typed
  • New translations have been added or updated if new strings have been introduced in the frontend
  • My migrations file are included
  • Are there enough tests
  • Documentation has been included (for new feature)

Doc

Tell us where the doc can be found (docs folder, wiki, in the code...).

Changes

Explain the changes that were made.

  • Add OffLineLangSwitch that doesn't try to fetch a user

How to test

Explain how to test your PR.

On a polio DB, without logging, go to http://localhost:8081/dashboard/polio/embeddedVaccineRepository/

use the language switch

Print screen / video

Screen.Recording.2024-11-22.at.11.40.03.mov

Notes

Can be Hotfixed on v1.248b-polio

Follow the Conventional Commits specification

The merge message of a pull request must follow the Conventional Commits specification.

This convention helps to automatically generate release notes.

Use lowercase for consistency.

Example:

fix: empty instance pop up

Refs: IA-3665

Note that the Jira reference is preceded by a line break.

Both the line break and the Jira reference are entered in the Add an optional extended description… field.

@beygorghor beygorghor self-requested a review November 25, 2024 10:32
Copy link
Collaborator

@beygorghor beygorghor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ You have changes form #1819

@quang-le quang-le merged commit ce924e8 into main Nov 25, 2024
3 checks passed
@quang-le quang-le deleted the POLIO-1751_embedded_pdf_translations branch November 25, 2024 11:22
@beygorghor beygorghor added the user tested Has already been tested on staging label Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Released user tested Has already been tested on staging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants