-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IA-3398 add warning when updating phone number #1618
IA-3398 add warning when updating phone number #1618
Conversation
- Update WarningModal o make it reusable - Add WarningModal if user updates existing phone number
- handle all warning cases in one modal
…g_when_updating_phone_number
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you have missing translations:
Please translate the translation containing CHECKME and remove it.
iaso.users.permAndPhoneWarningTitle
iaso.users.permAndPhoneWarningTitle
also i had the warning modale while only updating user name: Screen.Recording.2024-09-11.at.13.31.11.mov |
…g_when_updating_phone_number
I can't reproduce this one |
|
e353361
into
IA-3364_user_history_front-end
Explain what problem this PR is resolving
Related JIRA tickets : IA-3398
Self proofreading checklist
Doc
NA
Changes
WarningModal
to handle the warning about user permissions and phone numberWarningModal
inUsersDialog
How to test
Go to iaso > users > managment
open a user
Try and change the phone number
Print screen / video
Screen.Recording.2024-09-10.at.17.25.36.mov
Notes
merges into #1615