-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IA-3102: Permissions : Org unit “view only” permission #1558
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested it locally by adding just the read-only perm to a user but I can't see any org unit in the list and I've got a bunch of 403.
Is this normal?
Screen.Recording.2024-08-21.at.15.54.46.mov
…ng iaso_org_units_read permission
That's right, I omitted the read permission on the groups, data source. It is fixed with the commit . Thank you |
I think you are right we should disable the inputs too. Thank you, let me fix it! |
I'v just pushed the commit about disabling inputs when the use has not org unit managament permission. But there is on input |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Explain what problem this PR is resolving
Related JIRA tickets : IA-3102
Self proofreading checklist
Changes
How to test
Print screen / video
Screencast.from.2024-08-19.14-23-35.webm
Notes
Things that the reviewers should know: known bugs that are out of the scope of the PR, other trade-offs that were made.
If the PR depends on a PR in bluesquare-components, or merges into another PR (i.o. main), it should also be mentioned here