Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IA-3398 add warning when updating phone number #1618

Conversation

quang-le
Copy link
Member

@quang-le quang-le commented Sep 10, 2024

Explain what problem this PR is resolving

Related JIRA tickets : IA-3398

Self proofreading checklist

  • Did I use eslint and black formatters
  • Is my code clear enough and well documented
  • Are my typescript files well typed
  • New translations have been added or updated if new strings have been introduced in the frontend
  • My migrations file are included
  • Are there enough tests
  • Documentation has been included (for new feature)

Doc

NA

Changes

  • Update WarningModal to handle the warning about user permissions and phone number
  • Format the messages for WarningModal in UsersDialog

How to test

Go to iaso > users > managment

open a user
Try and change the phone number

Print screen / video

Screen.Recording.2024-09-10.at.17.25.36.mov

Notes

merges into #1615

- Update WarningModal o make it reusable
- Add WarningModal if user updates existing phone number
- handle all warning cases in one modal
@beygorghor beygorghor self-requested a review September 11, 2024 11:12
Copy link
Collaborator

@beygorghor beygorghor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have missing translations:
Please translate the translation containing CHECKME and remove it.
iaso.users.permAndPhoneWarningTitle
iaso.users.permAndPhoneWarningTitle

@beygorghor
Copy link
Collaborator

also i had the warning modale while only updating user name:

Screen.Recording.2024-09-11.at.13.31.11.mov

@quang-le
Copy link
Member Author

also i had the warning modale while only updating user name:
Screen.Recording.2024-09-11.at.13.31.11.mov

I can't reproduce this one

@quang-le quang-le requested a review from beygorghor September 12, 2024 14:11
@quang-le quang-le added the release Should be released in production at next deploy label Sep 12, 2024
@quang-le quang-le marked this pull request as draft September 12, 2024 16:27
@quang-le
Copy link
Member Author

also i had the warning modale while only updating user name:
Screen.Recording.2024-09-11.at.13.31.11.mov

I can't reproduce this one
I have it now, nevermind. Looking into it

@quang-le quang-le marked this pull request as ready for review September 12, 2024 16:35
@quang-le quang-le merged commit e353361 into IA-3364_user_history_front-end Sep 13, 2024
3 of 6 checks passed
@quang-le quang-le deleted the IA-3398_add_warning_when_updating_phone_number branch September 13, 2024 09:35
@kemar kemar removed the release Should be released in production at next deploy label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants