Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conda env for pytest in aml-benchmark #1822

Closed
wants to merge 6 commits into from
Closed

Conversation

iamrk04
Copy link
Contributor

@iamrk04 iamrk04 commented Nov 27, 2023

There are a couple of issues (listed below) with the default asset-test workflow which we want to avoid and hence we are creating our own workflow to make sure new changes do not break the existing functionality:

  • default asset-test workflow uses latest python version i.e. python==3.12, and some of the packages (azureml-dataprep and azureml-dataprep-native) that we depend upon do not have support for python==3.12, which simply breaks the workflow and we are unable to run our tests.
  • If we change code in multiple components, it triggers the test multiple times (for multiple components), which is unnecessary. We just want the test to be triggered once as all the tests will be executed for any change anywhere. (Please note we want to run all the tests for any change in the code anywhere, not just for change in component but also for change in test)

Update: To address the issue, we are now leveraging the conda_environment property for pytest.

Copy link

github-actions bot commented Nov 27, 2023

Test Results for aml-benchmark-test

220 tests   207 ✔️  33m 48s ⏱️
    1 suites      1 💤
    1 files      10   2 🔥

For more details on these failures and errors, see this check.

Results for commit 749535bd.

♻️ This comment has been updated with latest results.

vizhur
vizhur previously requested changes Dec 14, 2023
Copy link
Contributor

@vizhur vizhur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets not duplicate CIs and make improvements to the current one

Copy link

github-actions bot commented Dec 18, 2023

Test Results for assets-test

233 tests   225 ✔️  1h 45m 58s ⏱️
    1 suites      1 💤
    1 files        7

For more details on these failures, see this check.

Results for commit bbe8ff2.

♻️ This comment has been updated with latest results.

@iamrk04 iamrk04 changed the title Add separate test workflow for aml-benchmark Add sconda env for pytest in aml-benchmark Dec 18, 2023
@iamrk04 iamrk04 changed the title Add sconda env for pytest in aml-benchmark Add conda env for pytest in aml-benchmark Dec 18, 2023
@iamrk04 iamrk04 requested a review from vizhur December 18, 2023 10:06
@iamrk04 iamrk04 closed this Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants