-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add conda env for pytest in aml-benchmark #1822
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamrk04
force-pushed
the
rk/aml_workflow
branch
from
December 14, 2023 03:38
5341de2
to
006be6c
Compare
vizhur
reviewed
Dec 14, 2023
elesel
reviewed
Dec 14, 2023
vizhur
previously requested changes
Dec 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets not duplicate CIs and make improvements to the current one
iamrk04
force-pushed
the
rk/aml_workflow
branch
from
December 18, 2023 03:02
749535b
to
b52223a
Compare
iamrk04
changed the title
Add separate test workflow for aml-benchmark
Add sconda env for pytest in aml-benchmark
Dec 18, 2023
iamrk04
changed the title
Add sconda env for pytest in aml-benchmark
Add conda env for pytest in aml-benchmark
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a couple of issues (listed below) with the default asset-test workflow which we want to avoid and hence we are creating our own workflow to make sure new changes do not break the existing functionality:
azureml-dataprep
andazureml-dataprep-native
) that we depend upon do not have support for python==3.12, which simply breaks the workflow and we are unable to run our tests.Update: To address the issue, we are now leveraging the conda_environment property for pytest.