Allow AzCopy to receive OAuth tokens via GRPC for internal integrations #2778
+1,128
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adreed-msft
requested review from
gapra-msft,
dphulkar-msft,
vibhansa-msft,
seanmcc-msft,
souravgupta-msft and
tanyasethi-msft
as code owners
adreed-msft
force-pushed
the
adreed/grpc-control
branch
3 times, most recently
from
0510b55
to
6ca14e2
Compare
adreed-msft
force-pushed
the
adreed/grpc-control
branch
from
6ca14e2
to
d5386b2
Compare
vibhansa-msft
approved these changes
Oct 17, 2024
gapra-msft
reviewed
Oct 18, 2024
| // Inputs | ||
|
|
||
| // EventSubscriber = func(OAuthTokenUpdate) EmptyResponse | ||
| type OAuthTokenUpdate struct { |
There was a problem hiding this comment.
Why not just reference the one in common?
| "regexp" | ||
| ) | ||
|
|
||
| var ormetadataregex = regexp.MustCompile("((([A-F]|[a-f]|[0-9])+-?)+_?){2}") |
There was a problem hiding this comment.
This isn't necessary anymore right? (This was fixed in the SDK I'm assuming?)
There was a problem hiding this comment.
Also all the related changes in ste
gapra-msft
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds functionality to receive OAuth tokens over a HTTP/1.1 or HTTP/2 grpc message.
All functionality is behind a compile tag,
grpc.The token is shot in at about once per minute in the currently used integration. Requests trying to get an OAuth token pull a read lock on an RWMutex, and if the token is expired when the read is pulled, they wait up to 3x the validity of the last OAuth token for a fresh one. If no OAuth token is ever received within that timespan, it gives up, and signals to other requests to stop trying.
Injected tokens pull a write lock on the same RWMutex, and signals the
sync.Condto inform the requests waiting on a token a fresh one may be available.