Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CI artifacts for release improvements #10704

Open
wants to merge 10 commits into
base: dev
Choose a base branch
from
Open

Conversation

jviau
Copy link
Contributor

@jviau jviau commented Dec 18, 2024

Issue describing the changes in this PR

Pull request checklist

IMPORTANT: Currently, changes must be backported to the in-proc branch to be included in Core Tools and non-Flex deployments.

  • Backporting to the in-proc branch is not required
    • Otherwise: Link to backporting PR -- TODO
  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

Additional information

This PR refactors our build artifacts to support the upcoming release improvements. The changes are:

  1. SiteExtension and Symbols are no longer zipped.
    • The release pipeline will be responsible for zipping after it has made any changes (such as inserting jittraces)
  2. PrivateSiteExtension removed. A new script is now included which will transform site extension into the private site extension.
    • This reduces our artifact size significantly. Especially since private site extension is only occasionally needed.
  3. Windows artifacts consolidated under a single drop_windows artifact.
    • this is so the release pipeline can download only a single artifact.
  4. Release notes added to artifacts so the release pipeline can use them when creating a GitHub release
  5. We produce a new file release.json as a build artifact in drop_windows. This is used by the release pipeline for creating the GitHub release.
    • This is created by the site extension project via a New-ReleaseJson.ps1 script
  6. Linux artifacts renamed to drop_linux for consistency with windows drop.
  7. Adds a custom GetFileHas_Custom msbuild task to work around an issue with file path length in the existing msbuild task.

@jviau jviau requested a review from a team as a code owner December 18, 2024 21:33
@jviau jviau changed the title Refactor CI artifacts to no longer include Refactor CI artifacts for release improvements Dec 18, 2024
@jviau jviau added the area: engineering Engineering improvements label Dec 18, 2024
@jviau jviau force-pushed the jviau/eng/no-zip branch from 2c2640c to 9adf37f Compare January 8, 2025 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: engineering Engineering improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant