Remove unused FunctionsToolingSuffix #2753
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liliankasem
approved these changes
Oct 8, 2024
|
I believe Visual Studio takes a dependency on these properties for some behaviors. We should not remove them without confirming that. |
|
Closing while we verify if tooling has a dependency on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
resolves #issue_for_this_pr
Pull request checklist
release_notes.mdAdditional information
Removes the properties
_ToolingSuffixandFunctionsToolingSuffixfrom the SDK files. Their only usage was for an error, but beyond that there is no usage. This PR removes it, but we should discuss how valuable that error is to have. If we see value in this error, we should refactor to make it easier to add future versions.