Adding default settings to support SDK container builds #2671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Discussed briefly with @fabiocav, and we agree that this indeed makes sense as a 2.0 for the SDK. I will rebase and retarget the |
mattchenderson
force-pushed
the
mattchenderson/sdkcontainer
branch
from
2cb3067 to
f4b506c
Compare
7 tasks
mattchenderson
commented
Aug 28, 2024
sdk/Sdk/Targets/Microsoft.Azure.Functions.Worker.Sdk.Publish.targets
Outdated
Show resolved
Hide resolved
baronfel
approved these changes
Sep 4, 2024
sdk/Sdk/Targets/Microsoft.Azure.Functions.Worker.Sdk.Publish.targets
Outdated
Show resolved
Hide resolved
mattchenderson
force-pushed
the
mattchenderson/sdkcontainer
branch
2 times, most recently
from
f4b506c to
e26a3d7
Compare
fabiocav
force-pushed
the
feature/2.x
branch
from
1d03bef to
a09ee2b
Compare
mattchenderson
force-pushed
the
mattchenderson/sdkcontainer
branch
3 times, most recently
from
69435c0 to
73e8f32
Compare
fabiocav
force-pushed
the
feature/2.x
branch
from
f5a8c9a to
a538ec5
Compare
mattchenderson
force-pushed
the
mattchenderson/sdkcontainer
branch
from
73e8f32 to
758114b
Compare
brettsam
approved these changes
Sep 11, 2024
fabiocav
approved these changes
Sep 12, 2024
|
Pushing one more revision to fix the merge conflict on the release notes. Will then merge. |
mattchenderson
force-pushed
the
mattchenderson/sdkcontainer
branch
from
758114b to
13214b7
Compare
fabiocav
pushed a commit
that referenced
this pull request
Oct 11, 2024
brettsam
pushed a commit
that referenced
this pull request
Oct 21, 2024
fabiocav
pushed a commit
that referenced
this pull request
Oct 21, 2024
fabiocav
pushed a commit
that referenced
this pull request
Oct 21, 2024
fabiocav
pushed a commit
that referenced
this pull request
Nov 11, 2024
fabiocav
pushed a commit
that referenced
this pull request
Nov 13, 2024
fabiocav
pushed a commit
that referenced
this pull request
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
resolves #2617
Pull request checklist
release_notes.mdAdditional PR information
Because the tests associated with these changes require a docker daemon, I've moved them out of the default test set by setting a trait and applying a default filter which removes it. The relevant test can still be run by explicitly specifying the other runtime settings file included in the PR. Discussion may be needed around running this test within CI.
In addition to passes for the newly added tests, I have also manually tested the resulting output in both Windows and Linux, using .NET SDK 8.0.4 as per the discussion in #2641. The resulting images have no differences in included packages.
I would like to discuss the impact of these changes, as they would modify the default base image and some other settings for apps that are already using SDK container builds. Those would likely be unsuccessful today, so it is likely safe to do so. However, this still could be a change that warrants a major version revision.Edit: This now targets a new major version. See comment below.If someone is setting the properties explicitly, those would continue to be honored. I also defined a new property (
FunctionsContainerOmitDefaultEnvsVars) which can be used to suppress the environment variables being added should someone be customizing the other properties or have some other reason to modify them. It was not clear to me how I could otherwise conditionally avoid overwriting values that someone else had supplied for these.