Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning for v3 out of support. Fix incorrect build message. #2606

Merged
merged 6 commits into from
Jul 29, 2024
Merged

Add warning for v3 out of support. Fix incorrect build message. #2606

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
523428c
Fix incorrect build message
jviau Jul 16, 2024
f5b115a
update release_notes.md
jviau Jul 16, 2024
760e86c
Refactor AzureFunctionVersion default and error checks
jviau Jul 17, 2024
3ee43ed
Add warning for v3 out of support
jviau Jul 17, 2024
b28af4b
Merge remote-tracking branch 'upstream/main' into jviau/sdk/fix-message
jviau Jul 17, 2024
dfb21bc
Address PR comments
jviau Jul 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/Sdk/Targets/Microsoft.Azure.Functions.Worker.Sdk.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ WARNING: DO NOT MODIFY this file unless you are knowledgeable about MSBuild and

<!-- Validating some expectations for the function app early on. -->
<Target Name="_FunctionsPreBuild" BeforeTargets="BeforeBuild">
<Message Condition="'$(_AzureFunctionsNotSet)' == 'true'" Importance="high" Text="AzureFunctionsVersion not configured in the project. Setting AzureFunctionsVersion to v3"/>
<Message Condition="'$(_AzureFunctionsNotSet)' == 'true'" Importance="high" Text="AzureFunctionsVersion not configured in the project. Setting AzureFunctionsVersion to '$(AzureFunctionsVersion)'"/>
<Error Condition="$(AzureFunctionsVersion.StartsWith('v1',StringComparison.OrdinalIgnoreCase))" Text="AzureFunctionsVersion is set to an incompatible version, Please set it to v4"/>
<Error Condition="$(AzureFunctionsVersion.StartsWith('v2',StringComparison.OrdinalIgnoreCase))" Text="AzureFunctionsVersion is set to an incompatible version, Please set it to v3"/>
jviau marked this conversation as resolved.
Show resolved Hide resolved
<Error Condition="!$(AzureFunctionsVersion.StartsWith('v3',StringComparison.OrdinalIgnoreCase)) And !$(AzureFunctionsVersion.StartsWith('v4',StringComparison.OrdinalIgnoreCase))" Text="AzureFunctionsVersion is set to an incompatible version"/>
Expand Down
9 changes: 2 additions & 7 deletions sdk/release_notes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,6 @@
- My change description (#PR/#issue)
-->

### Microsoft.Azure.Functions.Worker.Sdk 1.17.4
### Microsoft.Azure.Functions.Worker.Sdk <version>

- Upgrade Microsoft.Azure.Functions.Worker.Sdk.Generators to 1.3.2

### Microsoft.Azure.Functions.Worker.Sdk.Generators 1.3.2

- Enhanced function metadata generation to include `$return` binding for HTTP trigger functions. (#1619)
- Updating generators to fix the namespace conflict with customer code (#2582)
- Fix incorrect function version in build message (#2606)
Loading