Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating generators to fix the namespace conflict with customer code #2582

Merged
merged 7 commits into from
Jul 10, 2024
Merged

Updating generators to fix the namespace conflict with customer code #2582

merged 7 commits into from
Jul 10, 2024

Conversation

surgupta-msft
Copy link
Contributor

@surgupta-msft surgupta-msft commented Jul 8, 2024 •
edited
Loading

Issue describing the changes in this PR

resolves #2581

Added "global::" prefix in FunctionExecutorGenerator and FunctionMetadataProviderGenerator to fix the namespace conflict with customer code. Similar commit for ExtensionStartupRunnerGenerator update - #2553

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

@surgupta-msft surgupta-msft requested review from kshyju, jviau and satvu July 9, 2024 19:09
@surgupta-msft surgupta-msft merged commit 53d764e into main Jul 10, 2024
29 checks passed
@surgupta-msft surgupta-msft deleted the surgupta/globalfix-functiongen branch July 10, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jviau jviau jviau approved these changes

@kshyju kshyju Awaiting requested review from kshyju

@satvu satvu Awaiting requested review from satvu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update generators to fix the namespace conflict with customer code
2 participants
@surgupta-msft @jviau