Hedging: Adds support for writes on multi region accounts #4706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
NaluTripician
changed the title
NaluTripician
added
the
Hedging
NaluTripician
requested review from
sboshra,
adityasa,
neildsh,
kirankumarkolli,
FabianMeiswinkel,
kirillg and
Pilchie
as code owners
...soft.Azure.Cosmos/src/Routing/AvailabilityStrategy/CrossRegionHedgingAvailabilityStrategy.cs
Outdated
Show resolved
Hide resolved
...soft.Azure.Cosmos/src/Routing/AvailabilityStrategy/CrossRegionHedgingAvailabilityStrategy.cs
Outdated
Show resolved
Hide resolved
kirankumarkolli
previously approved these changes
Oct 19, 2024
Pilchie
requested changes
Oct 19, 2024
…bilityStrategy.cs Co-authored-by: Fabian Meiswinkel <[email protected]>
…egionHedgingAvailabilityStrategy.cs Co-authored-by: Fabian Meiswinkel <[email protected]>
(Gone tests will fail on account reads so it cannot be tested with hedging)
NaluTripician
changed the title
Pilchie
reviewed
Nov 25, 2024
Microsoft.Azure.Cosmos/src/Routing/AvailabilityStrategy/AvailabilityStrategy.cs
Outdated
Show resolved
Hide resolved
...soft.Azure.Cosmos/src/Routing/AvailabilityStrategy/CrossRegionHedgingAvailabilityStrategy.cs
Outdated
Show resolved
Hide resolved
...soft.Azure.Cosmos/src/Routing/AvailabilityStrategy/CrossRegionHedgingAvailabilityStrategy.cs
Outdated
Show resolved
Hide resolved
NaluTripician
commented
Nov 25, 2024
...t.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/CosmosAvailabilityStrategyTests.cs
Outdated
Show resolved
Hide resolved
...t.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/CosmosAvailabilityStrategyTests.cs
Outdated
Show resolved
Hide resolved
...t.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/CosmosAvailabilityStrategyTests.cs
Outdated
Show resolved
Hide resolved
...t.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/CosmosAvailabilityStrategyTests.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Kevin Pilch <[email protected]>
Pilchie
approved these changes
Nov 25, 2024
microsoft-github-policy-service
bot
deleted the
users/nalutripician/hedgingMMWrites
branch
kundadebdatta
pushed a commit
that referenced
this pull request
Jan 8, 2025
# Pull Request Template
## Description
Adds support to use hedging on write requests for multimaster accounts.
Note that this does come with the caveat that there will be more 409
errors thrown by the SDK. This is expected and applications that adapt
this feature should be prepared to handle these exceptions.
This feature will also be an opt in feature for Availability Strategies
and users will need to especially specify that in the availability
strategy definition.
```
ItemRequestOptions requestOptions = new ItemRequestOptions
{
AvailabilityStrategy = new CrossRegionHedgingAvailabilityStrategy(
threshold: TimeSpan.FromMilliseconds(100),
thresholdStep: TimeSpan.FromMilliseconds(50),
multiMasterWritesEnabled: true)
};
```
## Type of change
Please delete options that are not relevant.
- [] New feature (non-breaking change which adds functionality)
## Closing issues
To automatically close an issue: closes #4457
---------
Co-authored-by: Fabian Meiswinkel <[email protected]>
Co-authored-by: Kevin Pilch <[email protected]>
This was referenced Jan 8, 2025
microsoft-github-policy-service bot
pushed a commit
that referenced
this pull request
Jan 8, 2025
# Pull Request Template ## Description This PR cherry-picks the following commits: - #4706 - #4869 ## Type of change Please delete options that are not relevant. - [x] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) ## Closing issues To automatically close an issue: closes #IssueNumber --------- Co-authored-by: Nalu Tripician <[email protected]> Co-authored-by: Fabian Meiswinkel <[email protected]> Co-authored-by: Kevin Pilch <[email protected]> Co-authored-by: dibahlfi <[email protected]> Co-authored-by: Arooshi Avasthy <[email protected]> Co-authored-by: Kiran Kumar Kolli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Adds support to use hedging on write requests for multimaster accounts. Note that this does come with the caveat that there will be more 409 errors thrown by the SDK. This is expected and applications that adapt this feature should be prepared to handle these exceptions.
This feature will also be an opt in feature for Availability Strategies and users will need to especially specify that in the availability strategy definition.
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #4457