Skip to content

Commit

Permalink
commit on some actionables
Browse files Browse the repository at this point in the history
  • Loading branch information
philipthomas-MSFT committed Oct 17, 2023
1 parent 048e019 commit e06da21
Showing 1 changed file with 14 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -3321,6 +3321,13 @@ private static async Task GivenItemStreamAsyncWhenMissingMemberHandlingIsErrorTh
CancellationTokenSource cancellationTokenSource = new();
CancellationToken cancellationToken = cancellationTokenSource.Token;

// Food for thought, actionable items.
//
// 1. Is there anything else that we should be concerned with that would give us the same behavior?
// 2. Are there other operations other than those that can yield an NotFound exception that we should be
// concerned with?
// 3. Can we also reset the DefaultSettings before we make the call, and reset it back once it is done?

JsonConvert.DefaultSettings = () => new JsonSerializerSettings
{
MissingMemberHandling = MissingMemberHandling.Error
Expand Down Expand Up @@ -3412,6 +3419,13 @@ private static async Task GivenItemAsyncWhenMissingMemberHandlingIsErrorThenExpe
CancellationTokenSource cancellationTokenSource = new();
CancellationToken cancellationToken = cancellationTokenSource.Token;

// Food for thought, actionable items.
//
// 1. Is there anything else that we should be concerned with that would give us the same behavior?
// 2. Are there other operations other than those that can yield an NotFound exception that we should be
// concerned with?
// 3. Can we also reset the DefaultSettings before we make the call, and reset it back once it is done?

JsonConvert.DefaultSettings = () => new JsonSerializerSettings
{
MissingMemberHandling = MissingMemberHandling.Error
Expand Down

0 comments on commit e06da21

Please sign in to comment.