Skip to content

Commit

Permalink
Azurecore: Fixes upgrading azure core dependency to latest (#4819)
Browse files Browse the repository at this point in the history
Azure.Core:  Fixed upgrading azure core dependency to 1.44.1

Changes
- ResourceType: Conflict between Azure.Core and
Microsoft.Azure.Cosmos.Documents
- Microsoft.Bcl.AsyncInterfaces: Azure.Core needs at-least 6.0.0 (as
Azure core upgraded part of minor version, we are good as well)
- Microsoft.Azure.Cosmos.Encryption.Custom: Direct dependency on
Azure.Core removed (now its transitive)
- Microsoft.Azure.Cosmos.Encryption.Custom.Performance.Tests: `NU1903`
added Newtonsoft.Json dependency
- Performance project: `NU1903` Newtonsoft dependency upgraded
  • Loading branch information
kirankumarkolli authored Oct 18, 2024
1 parent ac9d503 commit 80e38b9
Show file tree
Hide file tree
Showing 11 changed files with 12 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,9 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="Azure.Core" Version="1.38.0" />
<PackageReference Include="Azure.Identity" Version="1.11.4" />
<PackageReference Include="System.Text.RegularExpressions" Version="4.3.1" />
<PackageReference Include="System.Threading.Tasks.Extensions" Version="4.5.4" />
<PackageReference Include="System.Threading.Tasks.Extensions" Version="4.5.4" />
</ItemGroup>

<ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
<ItemGroup>
<PackageReference Include="BenchmarkDotNet" Version="0.13.3" />
<PackageReference Include="Moq" Version="4.13.1" />
<PackageReference Include="Newtonsoft.Json" Version="13.0.3" />
</ItemGroup>

<ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="Azure.Core" Version="1.19.0" />
<PackageReference Include="System.Text.RegularExpressions" Version="4.3.1" />
<PackageReference Include="System.Threading.Tasks.Extensions" Version="4.5.4" />
</ItemGroup>
Expand Down
1 change: 1 addition & 0 deletions Microsoft.Azure.Cosmos/src/CosmosClient.cs
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ namespace Microsoft.Azure.Cosmos
using Microsoft.Azure.Cosmos.Tracing;
using Microsoft.Azure.Cosmos.Tracing.TraceData;
using Microsoft.Azure.Documents;
using ResourceType = Documents.ResourceType;

/// <summary>
/// Provides a client-side logical representation of the Azure Cosmos DB account.
Expand Down
1 change: 1 addition & 0 deletions Microsoft.Azure.Cosmos/src/DocumentClient.cs
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ namespace Microsoft.Azure.Cosmos
using Microsoft.Azure.Documents.FaultInjection;
using Microsoft.Azure.Documents.Routing;
using Newtonsoft.Json;
using ResourceType = Documents.ResourceType;

/// <summary>
/// Provides a client-side logical representation for the Azure Cosmos DB service.
Expand Down
4 changes: 2 additions & 2 deletions Microsoft.Azure.Cosmos/src/Microsoft.Azure.Cosmos.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -112,11 +112,11 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="Azure.Core" Version="1.19.0" />
<PackageReference Include="Azure.Core" Version="1.44.1" />
<PackageReference Include="System.Collections.Immutable" Version="1.7.0" />
<PackageReference Include="System.Diagnostics.DiagnosticSource" Version="8.0.1" />
<PackageReference Include="System.Numerics.Vectors" Version="4.5.0" />
<PackageReference Include="Microsoft.Bcl.AsyncInterfaces" Version="1.0.0" />
<PackageReference Include="Microsoft.Bcl.AsyncInterfaces" Version="6.0.0" />
<PackageReference Include="Microsoft.VisualStudio.Threading.Analyzers" Version="16.0.102" PrivateAssets="All" />
<PackageReference Include="Newtonsoft.Json" Version="10.0.2" NoWarn="NU1903" />
<PackageReference Include="System.Net.Http" Version="4.3.4" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@
<PackageReference Include="MSTest.TestFramework" Version="1.3.2" />
<PackageReference Include="Newtonsoft.Json" Version="13.0.3" />
<PackageReference Include="System.Reflection" Version="4.3.0" />
<PackageReference Include="Azure.Core" Version="1.19.0" />
</ItemGroup>

<ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<Project Sdk="Microsoft.NET.Sdk">
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<OutputType>Exe</OutputType>
Expand All @@ -21,6 +21,7 @@
<PackageReference Include="Microsoft.Extensions.Configuration.EnvironmentVariables" Version="3.0.0" />
<PackageReference Include="Microsoft.Extensions.Configuration.Json" Version="3.0.0" />
<PackageReference Include="Moq" Version="4.13.1" />
<PackageReference Include="Newtonsoft.Json" Version="13.0.3" />
<PackageReference Include="System.Linq" Version="4.3.0" />
</ItemGroup>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -119,15 +119,15 @@ public void ProjectPackageDependenciesTest()
{ "System.Collections.Immutable", new Version(1, 7, 0) },
{ "System.Numerics.Vectors", new Version(4, 5, 0) },
{ "Newtonsoft.Json", new Version(10, 0, 2) },
{ "Microsoft.Bcl.AsyncInterfaces", new Version(1, 0, 0) },
{ "Microsoft.Bcl.AsyncInterfaces", new Version(6, 0, 0) },
{ "System.Configuration.ConfigurationManager", new Version(6, 0, 0) },
{ "System.Memory", new Version(4, 5, 5) },
{ "System.Buffers", new Version(4, 5, 1) },
{ "System.Runtime.CompilerServices.Unsafe", new Version(6, 0, 0) },
{ "System.Threading.Tasks.Extensions", new Version(4, 5, 4) },
{ "System.ValueTuple", new Version(4, 5, 0) },
{ "Microsoft.Bcl.HashCode", new Version(1, 1, 0) },
{ "Azure.Core", new Version(1, 19, 0) },
{ "Azure.Core", new Version(1, 44, 1) },
{ "System.Diagnostics.DiagnosticSource", new Version(8, 0, 1) },
{ "System.Net.Http", new Version(4, 3, 4) },
{ "System.Text.RegularExpressions", new Version(4, 3, 1) },
Expand All @@ -142,7 +142,7 @@ public void ProjectPackageDependenciesTest()
}

/// <summary>
/// Ignoring HybridRow dependency check as it is using System.Runtime.CompilerServices.Unsafe 4.5.3 and Azure.Core 1.19.0 needs >=4.6.0 version of the same
/// Ignoring HybridRow dependency check as it is using System.Runtime.CompilerServices.Unsafe 4.5.3 and Azure.Core 1.44.1 needs >=4.6.0 version of the same
/// </summary>
[TestMethod]
public void PackageDependenciesTest()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ namespace Microsoft.Azure.Cosmos.Tests
using Microsoft.Azure.Documents.Collections;
using Microsoft.VisualStudio.TestTools.UnitTesting;
using Moq;
using ResourceType = Documents.ResourceType;

[TestClass]
public class CosmosAuthorizationTests
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="Azure.Core" Version="1.19.0" />
<PackageReference Include="FluentAssertions" Version="5.10.3" />
<PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="2.1.1" />
<PackageReference Include="Microsoft.IdentityModel.Tokens" Version="6.7.1" />
Expand Down

0 comments on commit 80e38b9

Please sign in to comment.