Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Compute] BREAKING CHANGE: az snapshot: Migrate commands using Code Gen V2 #30486

Merged
merged 4 commits into from
Dec 9, 2024

Conversation

yanzhudd
Copy link
Contributor

@yanzhudd yanzhudd commented Dec 6, 2024

Related command

az snapshot create/update/grant-access

Description

Migrate snapshot command group to Code Gen V2
Note: The subcommand groups have not yet been migrated

AAZ PR: Azure/aaz#642

Testing Guide

History Notes

[Compute] BREAKING CHANGE: az snapshot: Refine output fields to align with backend service


This checklist is used to make sure that common guidelines for a pull request are followed.

@yanzhudd yanzhudd self-assigned this Dec 6, 2024
Copy link

azure-client-tools-bot-prd bot commented Dec 6, 2024

️✔️AzureCLI-FullTest
️✔️acr
️✔️2020-09-01-hybrid
️✔️3.12
️✔️3.9
️✔️latest
️✔️3.12
️✔️3.9
️✔️acs
️✔️2020-09-01-hybrid
️✔️3.12
️✔️3.9
️✔️latest
️✔️3.12
️✔️3.9
️✔️advisor
️✔️latest
️✔️3.12
️✔️3.9
️✔️ams
️✔️latest
️✔️3.12
️✔️3.9
️✔️apim
️✔️latest
️✔️3.12
️✔️3.9
️✔️appconfig
️✔️latest
️✔️3.12
️✔️3.9
️✔️appservice
️✔️latest
️✔️3.12
️✔️3.9
️✔️aro
️✔️latest
️✔️3.12
️✔️3.9
️✔️backup
️✔️latest
️✔️3.12
️✔️3.9
️✔️batch
️✔️latest
️✔️3.12
️✔️3.9
️✔️batchai
️✔️latest
️✔️3.12
️✔️3.9
️✔️billing
️✔️latest
️✔️3.12
️✔️3.9
️✔️botservice
️✔️latest
️✔️3.12
️✔️3.9
️✔️cdn
️✔️latest
️✔️3.12
️✔️3.9
️✔️cloud
️✔️latest
️✔️3.12
️✔️3.9
️✔️cognitiveservices
️✔️latest
️✔️3.12
️✔️3.9
️✔️compute_recommender
️✔️latest
️✔️3.12
️✔️3.9
️✔️computefleet
️✔️latest
️✔️3.12
️✔️3.9
️✔️config
️✔️latest
️✔️3.12
️✔️3.9
️✔️configure
️✔️latest
️✔️3.12
️✔️3.9
️✔️consumption
️✔️latest
️✔️3.12
️✔️3.9
️✔️container
️✔️latest
️✔️3.12
️✔️3.9
️✔️containerapp
️✔️latest
️✔️3.12
️✔️3.9
️✔️core
️✔️2018-03-01-hybrid
️✔️3.12
️✔️3.9
️✔️2019-03-01-hybrid
️✔️3.12
️✔️3.9
️✔️2020-09-01-hybrid
️✔️3.12
️✔️3.9
️✔️latest
️✔️3.12
️✔️3.9
️✔️cosmosdb
️✔️latest
️✔️3.12
️✔️3.9
️✔️databoxedge
️✔️2019-03-01-hybrid
️✔️3.12
️✔️3.9
️✔️2020-09-01-hybrid
️✔️3.12
️✔️3.9
️✔️latest
️✔️3.12
️✔️3.9
️✔️dls
️✔️latest
️✔️3.12
️✔️3.9
️✔️dms
️✔️latest
️✔️3.12
️✔️3.9
️✔️eventgrid
️✔️latest
️✔️3.12
️✔️3.9
️✔️eventhubs
️✔️latest
️✔️3.12
️✔️3.9
️✔️feedback
️✔️latest
️✔️3.12
️✔️3.9
️✔️find
️✔️latest
️✔️3.12
️✔️3.9
️✔️hdinsight
️✔️latest
️✔️3.12
️✔️3.9
️✔️identity
️✔️latest
️✔️3.12
️✔️3.9
️✔️iot
️✔️2019-03-01-hybrid
️✔️3.12
️✔️3.9
️✔️2020-09-01-hybrid
️✔️3.12
️✔️3.9
️✔️latest
️✔️3.12
️✔️3.9
️✔️keyvault
️✔️2018-03-01-hybrid
️✔️3.12
️✔️3.9
️✔️2020-09-01-hybrid
️✔️3.12
️✔️3.9
️✔️latest
️✔️3.12
️✔️3.9
️✔️lab
️✔️latest
️✔️3.12
️✔️3.9
️✔️managedservices
️✔️latest
️✔️3.12
️✔️3.9
️✔️maps
️✔️latest
️✔️3.12
️✔️3.9
️✔️marketplaceordering
️✔️latest
️✔️3.12
️✔️3.9
️✔️monitor
️✔️latest
️✔️3.12
️✔️3.9
️✔️mysql
️✔️latest
️✔️3.12
️✔️3.9
️✔️netappfiles
️✔️latest
️✔️3.12
️✔️3.9
️✔️network
️✔️2018-03-01-hybrid
️✔️3.12
️✔️3.9
️✔️latest
️✔️3.12
️✔️3.9
️✔️policyinsights
️✔️latest
️✔️3.12
️✔️3.9
️✔️privatedns
️✔️latest
️✔️3.12
️✔️3.9
️✔️profile
️✔️latest
️✔️3.12
️✔️3.9
️✔️rdbms
️✔️latest
️✔️3.12
️✔️3.9
️✔️redis
️✔️latest
️✔️3.12
️✔️3.9
️✔️relay
️✔️latest
️✔️3.12
️✔️3.9
️✔️resource
️✔️2018-03-01-hybrid
️✔️3.12
️✔️3.9
️✔️2019-03-01-hybrid
️✔️3.12
️✔️3.9
️✔️latest
️✔️3.12
️✔️3.9
️✔️role
️✔️latest
️✔️3.12
️✔️3.9
️✔️search
️✔️latest
️✔️3.12
️✔️3.9
️✔️security
️✔️latest
️✔️3.12
️✔️3.9
️✔️servicebus
️✔️latest
️✔️3.12
️✔️3.9
️✔️serviceconnector
️✔️latest
️✔️3.12
️✔️3.9
️✔️servicefabric
️✔️latest
️✔️3.12
️✔️3.9
️✔️signalr
️✔️latest
️✔️3.12
️✔️3.9
️✔️sql
️✔️latest
️✔️3.12
️✔️3.9
️✔️sqlvm
️✔️latest
️✔️3.12
️✔️3.9
️✔️storage
️✔️2018-03-01-hybrid
️✔️3.12
️✔️3.9
️✔️2019-03-01-hybrid
️✔️3.12
️✔️3.9
️✔️2020-09-01-hybrid
️✔️3.12
️✔️3.9
️✔️latest
️✔️3.12
️✔️3.9
️✔️synapse
️✔️latest
️✔️3.12
️✔️3.9
️✔️telemetry
️✔️2018-03-01-hybrid
️✔️3.12
️✔️3.9
️✔️2019-03-01-hybrid
️✔️3.12
️✔️3.9
️✔️2020-09-01-hybrid
️✔️3.12
️✔️3.9
️✔️latest
️✔️3.12
️✔️3.9
️✔️util
️✔️latest
️✔️3.12
️✔️3.9
️✔️vm
️✔️2018-03-01-hybrid
️✔️3.12
️✔️3.9
️✔️2019-03-01-hybrid
️✔️3.12
️✔️3.9
️✔️2020-09-01-hybrid
️✔️3.12
️✔️3.9
️✔️latest
️✔️3.12
️✔️3.9

Copy link

azure-client-tools-bot-prd bot commented Dec 6, 2024

⚠️AzureCLI-BreakingChangeTest
⚠️vm
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd snapshot grant-access cmd snapshot grant-access added parameter no_wait
⚠️ 1008 - ParaPropAdd snapshot grant-access cmd snapshot grant-access update parameter access_level: added property aaz_default=Read
⚠️ 1008 - ParaPropAdd snapshot grant-access cmd snapshot grant-access update parameter access_level: added property aaz_type=string
⚠️ 1008 - ParaPropAdd snapshot grant-access cmd snapshot grant-access update parameter access_level: added property type=string
⚠️ 1010 - ParaPropUpdate snapshot grant-access cmd snapshot grant-access update parameter access_level: updated property options from ['--access-level'] to ['--access', '--access-level']
⚠️ 1008 - ParaPropAdd snapshot grant-access cmd snapshot grant-access update parameter duration_in_seconds: added property aaz_type=int
⚠️ 1008 - ParaPropAdd snapshot grant-access cmd snapshot grant-access update parameter file_format: added property aaz_type=string
⚠️ 1008 - ParaPropAdd snapshot grant-access cmd snapshot grant-access update parameter file_format: added property type=string
⚠️ 1008 - ParaPropAdd snapshot grant-access cmd snapshot grant-access update parameter resource_group_name: added property aaz_type=string
⚠️ 1008 - ParaPropAdd snapshot grant-access cmd snapshot grant-access update parameter resource_group_name: added property type=string
⚠️ 1010 - ParaPropUpdate snapshot grant-access cmd snapshot grant-access update parameter resource_group_name: updated property name from resource_group_name to resource_group
⚠️ 1008 - ParaPropAdd snapshot grant-access cmd snapshot grant-access update parameter snapshot_name: added property aaz_type=string
⚠️ 1008 - ParaPropAdd snapshot grant-access cmd snapshot grant-access update parameter snapshot_name: added property type=string
⚠️ 1010 - ParaPropUpdate snapshot grant-access cmd snapshot grant-access update parameter snapshot_name: updated property options from ['--name', '-n'] to ['--name', '--snapshot-name', '-n']
⚠️ 1008 - ParaPropAdd snapshot update cmd snapshot update update parameter accelerated_network: added property aaz_type=bool
⚠️ 1008 - ParaPropAdd snapshot update cmd snapshot update update parameter accelerated_network: added property type=bool
⚠️ 1010 - ParaPropUpdate snapshot update cmd snapshot update update parameter accelerated_network: updated property choices from ['false', 'true'] to ['0', '1', 'f', 'false', 'n', 'no', 't', 'true', 'y', 'yes']
⚠️ 1008 - ParaPropAdd snapshot update cmd snapshot update update parameter architecture: added property aaz_type=string
⚠️ 1008 - ParaPropAdd snapshot update cmd snapshot update update parameter architecture: added property type=string
⚠️ 1008 - ParaPropAdd snapshot update cmd snapshot update update parameter disk_access: added property aaz_type=string
⚠️ 1008 - ParaPropAdd snapshot update cmd snapshot update update parameter disk_access: added property type=string
⚠️ 1008 - ParaPropAdd snapshot update cmd snapshot update update parameter disk_encryption_set: added property aaz_type=string
⚠️ 1008 - ParaPropAdd snapshot update cmd snapshot update update parameter disk_encryption_set: added property type=string
⚠️ 1008 - ParaPropAdd snapshot update cmd snapshot update update parameter encryption_type: added property aaz_type=string
⚠️ 1008 - ParaPropAdd snapshot update cmd snapshot update update parameter encryption_type: added property type=string
⚠️ 1008 - ParaPropAdd snapshot update cmd snapshot update update parameter network_access_policy: added property aaz_type=string
⚠️ 1008 - ParaPropAdd snapshot update cmd snapshot update update parameter network_access_policy: added property type=string
⚠️ 1008 - ParaPropAdd snapshot update cmd snapshot update update parameter no_wait: added property aaz_type=bool
⚠️ 1008 - ParaPropAdd snapshot update cmd snapshot update update parameter no_wait: added property choices=['0', '1', 'f', 'false', 'n', 'no', 't', 'true', 'y', 'yes']
⚠️ 1008 - ParaPropAdd snapshot update cmd snapshot update update parameter no_wait: added property nargs=?
⚠️ 1008 - ParaPropAdd snapshot update cmd snapshot update update parameter no_wait: added property type=bool
⚠️ 1008 - ParaPropAdd snapshot update cmd snapshot update update parameter properties_to_add: added property aaz_type=AAZGenericUpdateAddArg
⚠️ 1008 - ParaPropAdd snapshot update cmd snapshot update update parameter properties_to_remove: added property aaz_type=AAZGenericUpdateRemoveArg
⚠️ 1008 - ParaPropAdd snapshot update cmd snapshot update update parameter properties_to_set: added property aaz_type=AAZGenericUpdateSetArg
⚠️ 1008 - ParaPropAdd snapshot update cmd snapshot update update parameter public_network_access: added property aaz_type=string
⚠️ 1008 - ParaPropAdd snapshot update cmd snapshot update update parameter public_network_access: added property type=string
⚠️ 1008 - ParaPropAdd snapshot update cmd snapshot update update parameter resource_group_name: added property aaz_type=string
⚠️ 1008 - ParaPropAdd snapshot update cmd snapshot update update parameter resource_group_name: added property type=string
⚠️ 1010 - ParaPropUpdate snapshot update cmd snapshot update update parameter resource_group_name: updated property name from resource_group_name to resource_group
⚠️ 1008 - ParaPropAdd snapshot update cmd snapshot update update parameter sku: added property aaz_type=string
⚠️ 1008 - ParaPropAdd snapshot update cmd snapshot update update parameter sku: added property type=string
⚠️ 1008 - ParaPropAdd snapshot update cmd snapshot update update parameter snapshot_name: added property aaz_type=string
⚠️ 1008 - ParaPropAdd snapshot update cmd snapshot update update parameter snapshot_name: added property type=string
⚠️ 1010 - ParaPropUpdate snapshot update cmd snapshot update update parameter snapshot_name: updated property options from ['--name', '-n'] to ['--name', '--snapshot-name', '-n']

@yonzhan
Copy link
Collaborator

yonzhan commented Dec 6, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

github-actions bot commented Dec 6, 2024

⚠️Your changes in this PR will be released on Jan 14, 2025 due to CCOA (extend to Jan 6, 2025)

@yanzhudd yanzhudd marked this pull request as ready for review December 6, 2024 08:07
@yanzhudd yanzhudd merged commit dd424b8 into Azure:dev Dec 9, 2024
53 checks passed
@yanzhudd yanzhudd deleted the migrate-snapshot-command branch December 9, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot Compute az vm/vmss/image/disk/snapshot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants