-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Compute] BREAKING CHANGE: az snapshot
: Migrate commands using Code Gen V2
#30486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
|
rule | cmd_name | rule_message | suggest_message |
---|---|---|---|
snapshot grant-access | cmd snapshot grant-access added parameter no_wait |
||
snapshot grant-access | cmd snapshot grant-access update parameter access_level : added property aaz_default=Read |
||
snapshot grant-access | cmd snapshot grant-access update parameter access_level : added property aaz_type=string |
||
snapshot grant-access | cmd snapshot grant-access update parameter access_level : added property type=string |
||
snapshot grant-access | cmd snapshot grant-access update parameter access_level : updated property options from ['--access-level'] to ['--access', '--access-level'] |
||
snapshot grant-access | cmd snapshot grant-access update parameter duration_in_seconds : added property aaz_type=int |
||
snapshot grant-access | cmd snapshot grant-access update parameter file_format : added property aaz_type=string |
||
snapshot grant-access | cmd snapshot grant-access update parameter file_format : added property type=string |
||
snapshot grant-access | cmd snapshot grant-access update parameter resource_group_name : added property aaz_type=string |
||
snapshot grant-access | cmd snapshot grant-access update parameter resource_group_name : added property type=string |
||
snapshot grant-access | cmd snapshot grant-access update parameter resource_group_name : updated property name from resource_group_name to resource_group |
||
snapshot grant-access | cmd snapshot grant-access update parameter snapshot_name : added property aaz_type=string |
||
snapshot grant-access | cmd snapshot grant-access update parameter snapshot_name : added property type=string |
||
snapshot grant-access | cmd snapshot grant-access update parameter snapshot_name : updated property options from ['--name', '-n'] to ['--name', '--snapshot-name', '-n'] |
||
snapshot update | cmd snapshot update update parameter accelerated_network : added property aaz_type=bool |
||
snapshot update | cmd snapshot update update parameter accelerated_network : added property type=bool |
||
snapshot update | cmd snapshot update update parameter accelerated_network : updated property choices from ['false', 'true'] to ['0', '1', 'f', 'false', 'n', 'no', 't', 'true', 'y', 'yes'] |
||
snapshot update | cmd snapshot update update parameter architecture : added property aaz_type=string |
||
snapshot update | cmd snapshot update update parameter architecture : added property type=string |
||
snapshot update | cmd snapshot update update parameter disk_access : added property aaz_type=string |
||
snapshot update | cmd snapshot update update parameter disk_access : added property type=string |
||
snapshot update | cmd snapshot update update parameter disk_encryption_set : added property aaz_type=string |
||
snapshot update | cmd snapshot update update parameter disk_encryption_set : added property type=string |
||
snapshot update | cmd snapshot update update parameter encryption_type : added property aaz_type=string |
||
snapshot update | cmd snapshot update update parameter encryption_type : added property type=string |
||
snapshot update | cmd snapshot update update parameter network_access_policy : added property aaz_type=string |
||
snapshot update | cmd snapshot update update parameter network_access_policy : added property type=string |
||
snapshot update | cmd snapshot update update parameter no_wait : added property aaz_type=bool |
||
snapshot update | cmd snapshot update update parameter no_wait : added property choices=['0', '1', 'f', 'false', 'n', 'no', 't', 'true', 'y', 'yes'] |
||
snapshot update | cmd snapshot update update parameter no_wait : added property nargs=? |
||
snapshot update | cmd snapshot update update parameter no_wait : added property type=bool |
||
snapshot update | cmd snapshot update update parameter properties_to_add : added property aaz_type=AAZGenericUpdateAddArg |
||
snapshot update | cmd snapshot update update parameter properties_to_remove : added property aaz_type=AAZGenericUpdateRemoveArg |
||
snapshot update | cmd snapshot update update parameter properties_to_set : added property aaz_type=AAZGenericUpdateSetArg |
||
snapshot update | cmd snapshot update update parameter public_network_access : added property aaz_type=string |
||
snapshot update | cmd snapshot update update parameter public_network_access : added property type=string |
||
snapshot update | cmd snapshot update update parameter resource_group_name : added property aaz_type=string |
||
snapshot update | cmd snapshot update update parameter resource_group_name : added property type=string |
||
snapshot update | cmd snapshot update update parameter resource_group_name : updated property name from resource_group_name to resource_group |
||
snapshot update | cmd snapshot update update parameter sku : added property aaz_type=string |
||
snapshot update | cmd snapshot update update parameter sku : added property type=string |
||
snapshot update | cmd snapshot update update parameter snapshot_name : added property aaz_type=string |
||
snapshot update | cmd snapshot update update parameter snapshot_name : added property type=string |
||
snapshot update | cmd snapshot update update parameter snapshot_name : updated property options from ['--name', '-n'] to ['--name', '--snapshot-name', '-n'] |
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
microsoft-github-policy-service
bot
requested review from
yonzhan and
zhoxing-ms
December 6, 2024 06:49
microsoft-github-policy-service
bot
added
the
Compute
az vm/vmss/image/disk/snapshot
label
Dec 6, 2024
zhoxing-ms
reviewed
Dec 9, 2024
src/azure-cli/azure/cli/command_modules/vm/operations/snapshot.py
Outdated
Show resolved
Hide resolved
zhoxing-ms
reviewed
Dec 9, 2024
...li/azure/cli/command_modules/vm/azure_stack/profile_2020_09_01_hybrid/operations/snapshot.py
Outdated
Show resolved
Hide resolved
zhoxing-ms
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az snapshot create/update/grant-access
Description
Migrate
snapshot
command group to Code Gen V2Note: The subcommand groups have not yet been migrated
AAZ PR: Azure/aaz#642
Testing Guide
History Notes
[Compute] BREAKING CHANGE:
az snapshot
: Refine output fields to align with backend serviceThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.