Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Container] Update container cmdlets to use 2024-05-01-preview version API #30219

Conversation

drishtipeshwani09
Copy link

@drishtipeshwani09 drishtipeshwani09 commented Oct 29, 2024

Related command
az container

Description

  • We are in process of releasing some new features, one of them is a new azure resource called ContainerGroupProfile.
  • For that, added a new command group called az container container-group-profile, this includes commands related to various resource operations like create,list,show,delete and operations related to revisions.
  • Modified the az container create command to include new container group properties.
  • Additionally, added the required test scenarios.

Testing Guide

History Notes

[Container] BREAKING CHANGE: az container create: Remove default values set for --os-type, --cpu, --memory, --restart-policy arguments.
[Container] az container create: Add new arguments --config-map, --container-group-profile-id,
--container-group-profile-revision, -- standby-pool-profile-id, --fail-container-group-create-on-reuse-failure
for creating container group.
[Container] az container container-group-profile: Add new customer facing resource Container Group Profile.


This checklist is used to make sure that common guidelines for a pull request are followed.

Copy link

azure-client-tools-bot-prd bot commented Oct 29, 2024

️✔️AzureCLI-FullTest
️✔️acr
️✔️2020-09-01-hybrid
️✔️3.12
️✔️3.9
️✔️latest
️✔️3.12
️✔️3.9
️✔️acs
️✔️2020-09-01-hybrid
️✔️3.12
️✔️3.9
️✔️latest
️✔️3.12
️✔️3.9
️✔️advisor
️✔️latest
️✔️3.12
️✔️3.9
️✔️ams
️✔️latest
️✔️3.12
️✔️3.9
️✔️apim
️✔️latest
️✔️3.12
️✔️3.9
️✔️appconfig
️✔️latest
️✔️3.12
️✔️3.9
️✔️appservice
️✔️latest
️✔️3.12
️✔️3.9
️✔️aro
️✔️latest
️✔️3.12
️✔️3.9
️✔️backup
️✔️latest
️✔️3.12
️✔️3.9
️✔️batch
️✔️latest
️✔️3.12
️✔️3.9
️✔️batchai
️✔️latest
️✔️3.12
️✔️3.9
️✔️billing
️✔️latest
️✔️3.12
️✔️3.9
️✔️botservice
️✔️latest
️✔️3.12
️✔️3.9
️✔️cdn
️✔️latest
️✔️3.12
️✔️3.9
️✔️cloud
️✔️latest
️✔️3.12
️✔️3.9
️✔️cognitiveservices
️✔️latest
️✔️3.12
️✔️3.9
️✔️compute_recommender
️✔️latest
️✔️3.12
️✔️3.9
️✔️config
️✔️latest
️✔️3.12
️✔️3.9
️✔️configure
️✔️latest
️✔️3.12
️✔️3.9
️✔️consumption
️✔️latest
️✔️3.12
️✔️3.9
️✔️container
️✔️latest
️✔️3.12
️✔️3.9
️✔️containerapp
️✔️latest
️✔️3.12
️✔️3.9
️✔️core
️✔️2018-03-01-hybrid
️✔️3.12
️✔️3.9
️✔️2019-03-01-hybrid
️✔️3.12
️✔️3.9
️✔️2020-09-01-hybrid
️✔️3.12
️✔️3.9
️✔️latest
️✔️3.12
️✔️3.9
️✔️cosmosdb
️✔️latest
️✔️3.12
️✔️3.9
️✔️databoxedge
️✔️2019-03-01-hybrid
️✔️3.12
️✔️3.9
️✔️2020-09-01-hybrid
️✔️3.12
️✔️3.9
️✔️latest
️✔️3.12
️✔️3.9
️✔️dls
️✔️latest
️✔️3.12
️✔️3.9
️✔️dms
️✔️latest
️✔️3.12
️✔️3.9
️✔️eventgrid
️✔️latest
️✔️3.12
️✔️3.9
️✔️eventhubs
️✔️latest
️✔️3.12
️✔️3.9
️✔️feedback
️✔️latest
️✔️3.12
️✔️3.9
️✔️find
️✔️latest
️✔️3.12
️✔️3.9
️✔️hdinsight
️✔️latest
️✔️3.12
️✔️3.9
️✔️identity
️✔️latest
️✔️3.12
️✔️3.9
️✔️iot
️✔️2019-03-01-hybrid
️✔️3.12
️✔️3.9
️✔️2020-09-01-hybrid
️✔️3.12
️✔️3.9
️✔️latest
️✔️3.12
️✔️3.9
️✔️keyvault
️✔️2018-03-01-hybrid
️✔️3.12
️✔️3.9
️✔️2020-09-01-hybrid
️✔️3.12
️✔️3.9
️✔️latest
️✔️3.12
️✔️3.9
️✔️lab
️✔️latest
️✔️3.12
️✔️3.9
️✔️managedservices
️✔️latest
️✔️3.12
️✔️3.9
️✔️maps
️✔️latest
️✔️3.12
️✔️3.9
️✔️marketplaceordering
️✔️latest
️✔️3.12
️✔️3.9
️✔️monitor
️✔️latest
️✔️3.12
️✔️3.9
️✔️mysql
️✔️latest
️✔️3.12
️✔️3.9
️✔️netappfiles
️✔️latest
️✔️3.12
️✔️3.9
️✔️network
️✔️2018-03-01-hybrid
️✔️3.12
️✔️3.9
️✔️latest
️✔️3.12
️✔️3.9
️✔️policyinsights
️✔️latest
️✔️3.12
️✔️3.9
️✔️privatedns
️✔️latest
️✔️3.12
️✔️3.9
️✔️profile
️✔️latest
️✔️3.12
️✔️3.9
️✔️rdbms
️✔️latest
️✔️3.12
️✔️3.9
️✔️redis
️✔️latest
️✔️3.12
️✔️3.9
️✔️relay
️✔️latest
️✔️3.12
️✔️3.9
️✔️resource
️✔️2018-03-01-hybrid
️✔️3.12
️✔️3.9
️✔️2019-03-01-hybrid
️✔️3.12
️✔️3.9
️✔️latest
️✔️3.12
️✔️3.9
️✔️role
️✔️latest
️✔️3.12
️✔️3.9
️✔️search
️✔️latest
️✔️3.12
️✔️3.9
️✔️security
️✔️latest
️✔️3.12
️✔️3.9
️✔️servicebus
️✔️latest
️✔️3.12
️✔️3.9
️✔️serviceconnector
️✔️latest
️✔️3.12
️✔️3.9
️✔️servicefabric
️✔️latest
️✔️3.12
️✔️3.9
️✔️signalr
️✔️latest
️✔️3.12
️✔️3.9
️✔️sql
️✔️latest
️✔️3.12
️✔️3.9
️✔️sqlvm
️✔️latest
️✔️3.12
️✔️3.9
️✔️storage
️✔️2018-03-01-hybrid
️✔️3.12
️✔️3.9
️✔️2019-03-01-hybrid
️✔️3.12
️✔️3.9
️✔️2020-09-01-hybrid
️✔️3.12
️✔️3.9
️✔️latest
️✔️3.12
️✔️3.9
️✔️synapse
️✔️latest
️✔️3.12
️✔️3.9
️✔️telemetry
️✔️2018-03-01-hybrid
️✔️3.12
️✔️3.9
️✔️2019-03-01-hybrid
️✔️3.12
️✔️3.9
️✔️2020-09-01-hybrid
️✔️3.12
️✔️3.9
️✔️latest
️✔️3.12
️✔️3.9
️✔️util
️✔️latest
️✔️3.12
️✔️3.9
️✔️vm
️✔️2018-03-01-hybrid
️✔️3.12
️✔️3.9
️✔️2019-03-01-hybrid
️✔️3.12
️✔️3.9
️✔️2020-09-01-hybrid
️✔️3.12
️✔️3.9
️✔️latest
️✔️3.12
️✔️3.9

Copy link

azure-client-tools-bot-prd bot commented Oct 29, 2024

⚠️AzureCLI-BreakingChangeTest
⚠️container
rule cmd_name rule_message suggest_message
⚠️ 1011 - SubgroupAdd container container-group-profile sub group container container-group-profile added
⚠️ 1006 - ParaAdd container create cmd container create added parameter config_map
⚠️ 1006 - ParaAdd container create cmd container create added parameter container_group_profile_id
⚠️ 1006 - ParaAdd container create cmd container create added parameter container_group_profile_revision
⚠️ 1006 - ParaAdd container create cmd container create added parameter fail_container_group_create_on_reuse_failure
⚠️ 1006 - ParaAdd container create cmd container create added parameter standby_pool_profile_id
⚠️ 1009 - ParaPropRemove container create cmd container create update parameter cpu: removed property default=1
⚠️ 1009 - ParaPropRemove container create cmd container create update parameter memory: removed property default=1.5
⚠️ 1009 - ParaPropRemove container create cmd container create update parameter os_type: removed property default=Linux
⚠️ 1009 - ParaPropRemove container create cmd container create update parameter restart_policy: removed property default=Always

@yonzhan
Copy link
Collaborator

yonzhan commented Oct 29, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Auto-Assign Auto assign by bot label Oct 29, 2024
@drishtipeshwani09 drishtipeshwani09 changed the title [container] Modified az container commands for new properties such as ContainerGroupProfile, StandbyPoolProfile and ConfigMap [Container] Modified az container commands for new properties such as ContainerGroupProfile, StandbyPoolProfile and ConfigMap Oct 29, 2024
@drishtipeshwani09 drishtipeshwani09 changed the title [Container] Modified az container commands for new properties such as ContainerGroupProfile, StandbyPoolProfile and ConfigMap [Container] az container container-group-profile az container create Modified az container commands to add a new subgroup container-group-profile and new parameters for standby pool senario Oct 30, 2024
@drishtipeshwani09 drishtipeshwani09 changed the title [Container] az container container-group-profile az container create Modified az container commands to add a new subgroup container-group-profile and new parameters for standby pool senario [Container] Update container cmdlets to use 2024-05-01-preview version API Oct 31, 2024
@yonzhan
Copy link
Collaborator

yonzhan commented Nov 5, 2024

Please fix CI issues

@kaushik-ms
Copy link
Contributor

Please fix CI issues

The pr title has been changed.
The checks till points to previous title.
The --deployment-resource-group is not from our pr

@kaushik-ms
Copy link
Contributor

kaushik-ms commented Nov 5, 2024

for the option_length_too_long, exceptions are already added in linter_exclusions.yml

@kaushik-ms
Copy link
Contributor

AzureCLI-FullTest

@jrathore-msft
Copy link

@zhoxing-ms - can you please re-trigger the build so the checks can run again on the latest changes so that all checks are successful

@zhoxing-ms
Copy link
Contributor

image

@jrathore-msft Please resolve these CI issues

@yanzhudd
Copy link
Contributor

yanzhudd commented Nov 5, 2024

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@yanzhudd
Copy link
Contributor

yanzhudd commented Nov 5, 2024

replaced by a new PR: #30260

@yanzhudd yanzhudd closed this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants