[AKS] az aks create/update: Add support for feature Advanced Container Networking Services
#30208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
azure-client-tools-bot-prd
bot
added this to the November 2024 (2024-11-19)❗ Breaking change release ❗ milestone
|
Hi @snguyen64, |
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| aks create | cmd aks create added parameter disable_acns_observability |
||
| aks create | cmd aks create added parameter disable_acns_security |
||
| aks create | cmd aks create added parameter enable_acns |
||
| aks update | cmd aks update added parameter disable_acns_observability |
||
| aks update | cmd aks update added parameter disable_acns_security |
||
| aks update | cmd aks update added parameter disable_acns |
||
| aks update | cmd aks update added parameter enable_acns |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
snguyen64
changed the title
rayaisaiah
suggested changes
Oct 30, 2024
rayaisaiah
reviewed
Oct 30, 2024
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_managed_cluster_decorator.py
Outdated
Show resolved
Hide resolved
4 tasks
rayaisaiah
reviewed
Oct 30, 2024
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_aks_commands.py
Outdated
Show resolved
Hide resolved
rayaisaiah
suggested changes
Oct 31, 2024
src/azure-cli/azure/cli/command_modules/acs/managed_cluster_decorator.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/acs/managed_cluster_decorator.py
Show resolved
Hide resolved
rayaisaiah
reviewed
Oct 31, 2024
src/azure-cli/azure/cli/command_modules/acs/managed_cluster_decorator.py
Outdated
Show resolved
Hide resolved
rayaisaiah
reviewed
Oct 31, 2024
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_aks_commands.py
Show resolved
Hide resolved
rayaisaiah
suggested changes
Nov 1, 2024
rayaisaiah
reviewed
Nov 4, 2024
snguyen64
force-pushed
the
nguyensteven/acns-cli-2024-09-01
branch
4 times, most recently
from
18f6249 to
a5592e4
Compare
snguyen64
requested review from
zhoxing-ms,
jsntcy and
yanzhudd
as code owners
FumingZhang
reviewed
Nov 11, 2024
src/azure-cli/azure/cli/command_modules/acs/managed_cluster_decorator.py
Outdated
Show resolved
Hide resolved
zhoxing-ms
modified the milestones:
November 2024 (2024-11-19)❗ Breaking change release ❗,
December 2024 (2024-12-10)
address pr comments, remove redundant commands, add more tests, raise mutual exclusion errors for acns cases update test ctx convert one test to non cilium for enable acns update help msg update style update managed_cluster_decorator for acns and tests
snguyen64
force-pushed
the
nguyensteven/acns-cli-2024-09-01
branch
from
a5592e4 to
0b2d527
Compare
rayaisaiah
approved these changes
Nov 12, 2024
Draft
3 tasks
FumingZhang
reviewed
Nov 12, 2024
There was a problem hiding this comment.
Please fix lint errors
/mnt/vss/_work/1/s/src/azure-cli/azure/cli/command_modules/acs/managed_cluster_decorator.py:5775:48: E225 missing whitespace around operator
/mnt/vss/_work/1/s/src/azure-cli/azure/cli/command_modules/acs/managed_cluster_decorator.py:7384:1: W293 blank line contains whitespace
/mnt/vss/_work/1/s/src/azure-cli/azure/cli/command_modules/acs/managed_cluster_decorator.py:7387:1: W293 blank line contains whitespace
/mnt/vss/_work/1/s/src/azure-cli/azure/cli/command_modules/acs/managed_cluster_decorator.py:7404:51: E225 missing whitespace around operator
may bypass this check by updating src/azure-cli/azure/cli/command_modules/acs/linter_exclusions.yml
- FAIL - HIGH severity: option_length_too_long
Parameter: aks create,disable_acns_observability- The lengths of all options ['--disable-acns-observability'] are longer than threshold 22. Argument disable_acns_observability must have a short abbreviation.
Parameter: aks update,disable_acns_observability- The lengths of all options ['--disable-acns-observability'] are longer than threshold 22. Argument disable_acns_observability must have a short abbreviation.
src/azure-cli/azure/cli/command_modules/acs/managed_cluster_decorator.py
Outdated
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Requeued live test, test passed!
|
|
please list the changelog in the History Notes section with impacted commands/parameters, e.g., [AKS] |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
snguyen64
changed the title
az aks create/update: Add support for feature Advanced Container Networking Services
updated history and pr title. |
I tweaked the changelog a bit |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
FumingZhang
approved these changes
Nov 13, 2024
|
It looks good to me. |
|
@yanzhudd We needed this PR for GA feature which for announced in Ignite, can i know why this did not get into Nov 19th CLI 2.67 version ? And is there a possibility to get a minor release done with this PR ? |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
yanzhudd
approved these changes
Nov 20, 2024
yanzhudd
pushed a commit
to yanzhudd/azure-cli
that referenced
this pull request
Nov 25, 2024
…ner Networking Services (Azure#30208)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az aks create --enable-acns
az aks create --enable-acns --disable-acns-observability
az aks create --enable-acns --disable-acns-security
az aks update --enable-acns
az aks update --disable-acns
az aks update --enable-acns --disable-acns-observability
az aks update --enable-acns --disable-acns-security
Description
This PR adds commands to aks create and update to enable and disable ACNS and ACNS features for observability and security.
Testing Guide
--enable-acns will enable ACNS with all sub features (observability and security), except on non-cilium dataplane where security is disabled by default until security features are supported. This will have optional flags to enable and disable ACNS related features.
--disable-acns will disable all ACNS features on a cluster.
History Notes
[AKS]
az aks create/update: Add--enable-acnsparameter to support enabling advanced networking functionalities on a cluster[AKS]
az aks create/update: Add--disable-acns-observabilityparameter to disable advanced networking observability features when enabling advanced networking features with--enable-acns[AKS]
az aks create/update: Add--disable-acns-securityparameter to disable advanced networking security features when enabling advanced networking features with--enable-acns[AKS]
az aks update: Add--disable-acnsparameter to support disabling advanced networking functionalities on a clusterThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.