{Service Fabric} update python package and recordings #30205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwesigwaguma
requested review from
zhoxing-ms,
jsntcy and
yanzhudd
as code owners
️✔️AzureCLI-FullTest
|
azure-client-tools-bot-prd
bot
added this to the November 2024 (2024-11-19)❗ Breaking change release ❗ milestone
|
Hi @mwesigwaguma, |
️✔️AzureCLI-BreakingChangeTest
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
mwesigwaguma
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
zhoxing-ms
changed the title
zhoxing-ms
reviewed
Nov 11, 2024
| @@ -22,9 +22,9 @@ def test_managed_app_type(self): | |||
| 'vm_password': self.create_random_name('Pass@', 9), | |||
| 'app_type_name': 'VotingType', | |||
| 'v1': '1.0.0', | |||
| 'app_package_v1': 'https://azclistaccounttest.blob.core.windows.net/azclicont/Voting.sfpkg?sp=r&st=2024-03-11T19:56:24Z&se=2024-04-07T03:56:24Z&sv=2022-11-02&sr=b&sig=hi56byw0jYpSLnJtMNemqHe92cZTMJgMHyeGa7GtN9E%3D', | |||
| 'app_package_v1': 'https://sfmccliapptest.blob.core.windows.net/votingcont/Voting.sfpkg?sp=racwdyti&st=2024-10-28T05:39:21Z&se=2024-11-09T14:39:21Z&sv=2022-11-02&sr=b&sig=%2Fla1dP9YB3rLuyi5Nb0i6XDtTZSWb16IiUA%2BA7PLy4Q%3D', | |||
There was a problem hiding this comment.
Why do you need to change the URL of app_package_v1?
There was a problem hiding this comment.
because the storage account with the package was deleted, had to create another one
There was a problem hiding this comment.
Why not consider dynamically creating storage accounts in the test? Otherwise, there is still a risk that this storage account will be deleted in the future
There was a problem hiding this comment.
I can put up a seperate PR to update this.
zhoxing-ms
modified the milestones:
November 2024 (2024-11-19)❗ Breaking change release ❗,
December 2024 (2024-12-10)
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
zhoxing-ms
modified the milestones:
January 2025 (2025-01-14),
February 2025 (2025-02-11)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.