Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{AKS} [BREAKING CHANGE]: az aks create/update: Remove --uptime-sla and --no-uptime-sla options #8229

Merged
merged 3 commits into from
Nov 4, 2024

Conversation

FumingZhang
Copy link
Member


This checklist is used to make sure that common guidelines for a pull request are followed.

Sync the changes in official azure-cli #30221.

Related command

  • az aks create
  • az aks update

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Nov 4, 2024

❌Azure CLI Extensions Breaking Change Test
❌aks-preview
rule cmd_name rule_message suggest_message
1007 - ParaRemove aks create cmd aks create removed parameter uptime_sla please add back parameter uptime_sla for cmd aks create
1007 - ParaRemove aks update cmd aks update removed parameter no_uptime_sla please add back parameter no_uptime_sla for cmd aks update
1007 - ParaRemove aks update cmd aks update removed parameter uptime_sla please add back parameter uptime_sla for cmd aks update

Copy link

Hi @FumingZhang,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Collaborator

yonzhan commented Nov 4, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

github-actions bot commented Nov 4, 2024

Hi @FumingZhang

⚠️ Release Requirements

Module: aks-preview

  • ⚠️ Please update VERSION to be 9.0.0b9 in src/aks-preview/setup.py

Notes

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Nov 4, 2024
@zhoxing-ms zhoxing-ms removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Nov 4, 2024
@zhoxing-ms zhoxing-ms merged commit d7e4cef into Azure:main Nov 4, 2024
27 of 29 checks passed
@azclibot
Copy link
Collaborator

azclibot commented Nov 4, 2024

[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/release/_build/results?buildId=203063&view=results

chrisribe pushed a commit to chrisribe/azure-cli-extensions that referenced this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants