add admin component #569
Open
add admin component #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katherinelc321
requested review from
bennerv,
jharrington22,
mjlshen,
UlrichSchlueter and
zgalor
as code owners
mjlshen
suggested changes
Sep 5, 2024
admin/pkg/admin/adminResourceList.go
Outdated
There was a problem hiding this comment.
Up to you to decide (because the goal can totally change), but let's say that the goal of this Geneva Action is to get a list of all clusters from OCM. This will probably look something like:
GET /v1/ocm/clusters
With room for a future Geneva Action to provide cluster_id or cluster_name, like
GET /v1/ocm/clusters/id/${ID}
GET /v1/ocm/clusters?name=mycluster
I think this workload's "API" will be radically different from the RP/frontend
|
Please rebase pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Adds a new folder for the admin api
Compiling and testing locally works with this:
curl -X GET "0.0.0.0:8443/v1/ocm/clusters?api-version=2024-06-10-preview"Jira: https://issues.redhat.com/browse/ARO-9997
Link to demo recording:
Special notes for your reviewer