Skip to content
This repository has been archived by the owner on Oct 27, 2022. It is now read-only.

The Grand Pull Request #32

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

The Grand Pull Request #32

wants to merge 11 commits into from

Conversation

MrSerge01
Copy link
Collaborator

@MrSerge01 MrSerge01 commented Jul 20, 2022

Important changes

  • Ported the bot to the latest discord.js version. (v14.0.3)

Ported the bot to TypeScript

  • Port examples
  • Port utilities (like multiReact and handlers)
  • Port Discord events
  • Port other events
  • Port commands

Added

CONTRIBUTING.md

  • Made the guide up-to-date!

Proper events

  • Made an events handler
  • Made Discord events (like "messageCreate") as separate files
  • Made Other events (like "honk") as separate files [buggy]
  • Made Other events examples (similar to command examples)

Changed

README.md

  • Added the banner
  • Added badges

Dependencies

  • Updated octokit to the latest version
  • Updated discord.js to the latest version

Commands

  • Embed-ified all responses that weren't an embed
  • Rewritten the command handler

Removed

Dependencies

  • NODEMON!!!!!!!
  • eventsource
  • @octokit/webhooks

README.md

  • Old contribution guidelines

Actual code

  • Normal commands

Bug fixes

  • The LOA command requiring both Figma and GitHub accounts
  • The poll command having no buttons
  • The events not working
  • The commands not working

Known issues

  • LOA command requires both Figma and GitHub accounts.
  • Poll command has no buttons.
  • Events not working.
  • Commands not working.

People who... (Credits)

Helped make events work:

Helped port the bot to TS:

Helped with bug fixing:

Suggested features:

Bug fixing example file:

And of course, who created this PR?

@AZProductions
Copy link
Member

Pro

@AZProductions AZProductions self-requested a review July 20, 2022 08:08
@MrSerge01
Copy link
Collaborator Author

Pro

thankx, next commit aims at fixing known issues and getting events to work, since interactionCreate and messageCreate both error.

@MrSerge01
Copy link
Collaborator Author

Pro

thankx, next commit aims at fixing known issues and getting events to work, since interactionCreate and messageCreate both error.

update: broken send help AAAAAAAAAAA

@TechStudent10
Copy link
Contributor

Yay I'm in the credits!

@MrSerge01
Copy link
Collaborator Author

Yay I'm in the credits!

congrats, you deserve to be there :)

@MrSerge01
Copy link
Collaborator Author

soon:tm: huge commit that brings TS 👀

@Froxcey
Copy link
Contributor

Froxcey commented Jul 29, 2022

Please just commit, that way I can also do stuff.

@MrSerge01
Copy link
Collaborator Author

MrSerge01 commented Jul 29, 2022

it aint gonna even launch in the state it is currently 💀 @Froxcey
anyways, committing

@TechStudent10
Copy link
Contributor

@MrSerge01 please change TechStudent11 to TechStudent10 because I changed my username.

(I really didn't think this through)

@TechStudent10
Copy link
Contributor

  • (he left noooo)

xD any progress on the TS rewrite?

@MrSerge01
Copy link
Collaborator Author

  • (he left noooo)

xD any progress on the TS rewrite?

Sadly, no. We plan to rewrite the bot ENTIRELY due to some factors stopping us from rewriting the bot to TypeScript.

@TechStudent10
Copy link
Contributor

  • (he left noooo)

xD any progress on the TS rewrite?

Sadly, no. We plan to rewrite the bot ENTIRELY due to some factors stopping us from rewriting the bot to TypeScript.

Oomph. Well good luck. I'll try to help if I can (that means if I can understand anything)

@MrSerge01
Copy link
Collaborator Author

MrSerge01 commented Aug 6, 2022

  • (he left noooo)

xD any progress on the TS rewrite?

Sadly, no. We plan to rewrite the bot ENTIRELY due to some factors stopping us from rewriting the bot to TypeScript.

Oomph. Well good luck. I'll try to help if I can (that means if I can understand anything)

WHOA YOU STILL ARE ACTIVE LET'S GOOO

@TechStudent10
Copy link
Contributor

WHOA YOU STILL ARE ACTIVE LET'S GOOO

XD

@MrSerge01
Copy link
Collaborator Author

Anyways, thank you for requesting help.

@TechStudent10
Copy link
Contributor

Anyways, thank you for requesting help.

Requesting to help

@MrSerge01
Copy link
Collaborator Author

Canceled. I'm currently working on another bot which is not as badly made as this.

@TechStudent10
Copy link
Contributor

Canceled. I'm currently working on another bot which is not as badly made as this.

Another bot for AvdanOS? If so, can I help?

@MrSerge01
Copy link
Collaborator Author

MrSerge01 commented Oct 2, 2022

Canceled. I'm currently working on another bot which is not as badly made as this.

Another bot for AvdanOS? If so, can I help?

The bot I'm working on is not just for AvdanOS, but it will replace Tinan when it's going to be released.

You can help if you want.

@TechStudent10
Copy link
Contributor

Canceled. I'm currently working on another bot which is not as badly made as this.

Another bot for AvdanOS? If so, can I help?

The bot I'm working on is not just for AvdanOS, but it will replace Tinan when it's going to be released.

You can help if you want.

Alright! Can you add me to the repo?

@MrSerge01
Copy link
Collaborator Author

Canceled. I'm currently working on another bot which is not as badly made as this.

Another bot for AvdanOS? If so, can I help?

The bot I'm working on is not just for AvdanOS, but it will replace Tinan when it's going to be released.

You can help if you want.

Alright! Can you add me to the repo?

I am currently discussing with the team of that project.

@MrSerge01
Copy link
Collaborator Author

Update: @TechStudent10 You're in! If you read this, you probably already received an invitation.

@TechStudent10
Copy link
Contributor

Nice!

@TechStudent10
Copy link
Contributor

@MrSerge01 I didn't get an invite.

@MrSerge01
Copy link
Collaborator Author

@MrSerge01 I didn't get an invite.

Check your email, maybe? I see you as invited, you just have to accept it.

@TechStudent10
Copy link
Contributor

@MrSerge01 I didn't get an invite.

Check your email, maybe? I see you as invited, you just have to accept it.

I just checked. Not there. Can you invite me again?

@TechStudent10
Copy link
Contributor

TechStudent10 commented Oct 8, 2022

@MrSerge01 Can you please resent the invite?

@MrSerge01
Copy link
Collaborator Author

MrSerge01 commented Oct 8, 2022

@MrSerge01 Can you please resent the invite?

I already did...?

By the way, it was an invite to the organisation, not the repo. I don't know why it doesn't send you the invite even tho it's displaying for me perfectly.

You can check https://github.com/EntityTheBot because i think if you go there you will receive a notification saying you're invited there.

@TechStudent10
Copy link
Contributor

@MrSerge01 Can you please resent the invite?

I already did...?

By the way, it was an invite to the organisation, not the repo. I don't know why it doesn't send you the invite even tho it's displaying for me perfectly.

You can check https://github.com/EntityTheBot because i think if you go there you will receive a notification saying you're invited there.

aha got it thanks

@MrSerge01
Copy link
Collaborator Author

@MrSerge01 Can you please resent the invite?

I already did...?
By the way, it was an invite to the organisation, not the repo. I don't know why it doesn't send you the invite even tho it's displaying for me perfectly.
You can check https://github.com/EntityTheBot because i think if you go there you will receive a notification saying you're invited there.

aha got it thanks

Do you want to join the Discord server to communicate with the team?

@TechStudent10
Copy link
Contributor

@MrSerge01 Can you please resent the invite?

I already did...?
By the way, it was an invite to the organisation, not the repo. I don't know why it doesn't send you the invite even tho it's displaying for me perfectly.
You can check https://github.com/EntityTheBot because i think if you go there you will receive a notification saying you're invited there.

aha got it thanks

Do you want to join the Discord server to communicate with the team?

Yeah sure

@MrSerge01
Copy link
Collaborator Author

MrSerge01 commented Oct 9, 2022

@MrSerge01 Can you please resent the invite?

I already did...?
By the way, it was an invite to the organisation, not the repo. I don't know why it doesn't send you the invite even tho it's displaying for me perfectly.
You can check https://github.com/EntityTheBot because i think if you go there you will receive a notification saying you're invited there.

aha got it thanks

Do you want to join the Discord server to communicate with the team?

Yeah sure

Unblock me on Discord and send me a friend request.

@TechStudent10
Copy link
Contributor

@MrSerge01 Can you please resent the invite?

I already did...?
By the way, it was an invite to the organisation, not the repo. I don't know why it doesn't send you the invite even tho it's displaying for me perfectly.
You can check https://github.com/EntityTheBot because i think if you go there you will receive a notification saying you're invited there.

aha got it thanks

Do you want to join the Discord server to communicate with the team?

Yeah sure

Unblock me on Discord and send me a friend request.

I didn't even block you but okay.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
Status: Sep-Oct 2022
Development

Successfully merging this pull request may close these issues.

4 participants