Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created initial structure to My Home Launchpad using the entire home #98372

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

paulopmt1
Copy link
Contributor

@paulopmt1 paulopmt1 commented Jan 14, 2025

Related to #98348 and #98349

Proposed Changes

  • We're adding a new feature flag called home-launchpad which will add support to the Launchpad using the entire Home
  • Hide all home content except the Launchpad when the feature flag home-launchpad and the launchpadOnly get parameter is received at the home page

Note: We're adding both the feature flag + URL parameter because in the following iterations, some components will use the feature flag to behave differently and the /home page will use both parameters. With this feature flag we can easily isolate the deliverables of this project.

image

Why are these changes being made?

  • This is part of Launchpad In My Home project: pet6gk-1T7-p2

Testing Instructions

  • Go to your home page and add the following parameters to it: ?flags=home-launchpad&launchpadOnly=true

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

matticbot commented Jan 14, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~55 bytes added 📈 [gzipped])

name  parsed_size           gzip_size
home       +168 B  (+0.0%)      +55 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • command-palette-wp-admin
  • help-center
  • notifications
  • odyssey-stats
  • whats-new

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/prepare-my-home-launchpad on your sandbox.

@paulopmt1 paulopmt1 requested a review from a team January 14, 2025 17:43
@paulopmt1 paulopmt1 self-assigned this Jan 14, 2025
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task: Hide all Calypso home when in the new Launchpad Task: Create a feature flag for launchpad in My Home
2 participants