-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reader: Add utils for user profile #98346
base: loop-273/update-avatar-links
Are you sure you want to change the base?
Reader: Add utils for user profile #98346
Conversation
Previously, if the user had used the magic-link before, we should them a "Previously used: Email me a magic link" button and changed the button on the right from "Email me a login link" to "Continue with email". This has led to confusion with some users being unsure of how to login with a password. To that end, we've changed it so that the "Email Address or Username" is visible when the previously-used login method was magic-login. The social button on the right will also always read "Email me a login link". We're not moving the "Password" input at this point since there's a lot of infrastructure for other login flows that depends on the password being entered in a second step. All other social logins will remain the same and appear under "Previously used".
* Fix spacing issue for 100-year domains * Fix spacing and missing background colour
#98182) * provide a memoized based that's not dependent on goals to prevent event from firing each time goals are selected * stringify the goals * use only the initial goal reference to trigger event * add comment for clarity
* Remove Hosting list and card component. * Remove WPCOM overview components and move utils and hooks to shared folder. * Remove unused Pressable overview components. * Hide Breadcrumbs on mobile.
…upport them (#98132) The action attempts to trigger the sftp handlers registered in the data layer.
* Update display name for business role in support chat messages * Localize business role display name in support chat messages
…#98206) Co-authored-by: cpap <[email protected]>
* fixes the outperformed percentages when in evergreen * fixes the duration strings for evergreen campaigns * dont include orders in the orders if not in completed status
…#98113) * Accept icons on breadcrumb items * Hide header when in site context * Reduce font-size for small sizes with first-grapheme style * Add breadcrumb to the Domains page on site context * Use NavigationHeader * Revert hideHeader to avoid conflicts
Co-authored-by: sdnunca <[email protected]>
* ➖ REMOVE: remove extra localize function from ReaderAvatar * UPDATE: jsconfig for improving TS speed * UPDATE: migrate ReaderAuthorLink to TypeScript * REFACTOR: Update ReaderFollowButton to use TypeScript * REFACTOR: Update AuthorCompactProfile to functional component and use TypeScript * ➕ ADDS: author info and improve styling * ➖ REMOVE: extra user tabs * 👌 IMPROVE: selector namings and section alignments * ➕ ADDS: empty content placeholders in user profile * 🔨 REFACTOR: update EmptyContent to functional component and use TypeScript * 💫 UPDATE: only keep code related to refactor * FIX: actionURL in EmptyContent * ➖ REMOVE: code related to refactoring * Reader: Pass header content to Stream components * Remove reducer update from this PR * Remove optional modifier and rename children to headerContent * Create UserProfileHeader component * Move nav into header and use header directly in views * IMPROVE: spacing and remove extra properties * 🔨 REFACTOR: move header styles to its dedicated file * Move UserProfileHeader to own folder and scope CSS --------- Co-authored-by: Mehmood Ahmad <[email protected]>
…stead of the actual value (#98223)
Co-authored-by: vykes-mac <[email protected]>
- Forces redirects from Calypso to WP Admin for the E2E tests - Updates the E2E tests to use the WP Admin UI
* Refactoring shouldUseHelpCenterExperience * Simplify code * Unused types * Refactor again * Missing refactor * Refactor * Fix styling * Remove unnecessary spread operator Co-authored-by: Omar Alshaker <[email protected]> * Update packages/help-center/src/components/help-center-feedback-form.tsx Co-authored-by: Anthony Grullon <[email protected]> --------- Co-authored-by: Omar Alshaker <[email protected]> Co-authored-by: Anthony Grullon <[email protected]>
…atrix (#97049) * Update bug_report.yml Updated new issue template in support of an updated issue priority and severity matrix: p58i-ipi-p2 * Update template title * Bring back issue type * Bring back predefined labels * Remove invitation to subscribe * Update wording See #97049 (comment) * Adjust whitespace * Update wording Co-authored-by: Ikem <[email protected]> --------- Co-authored-by: Jeremy Herve <[email protected]>
* Add empty user profile content * Add translation
* Stats: update locations title dynamically * Put location title together with the map
* Add subscribers-dataviews flag and component. * Remove unnecessary code. * Show Launchpad or table. * Enable server-side search. * Add server-side sorting. * Render subscription type. * Align header. * Only show name field on mobile. * Add subscriber profile and mobile styles. * Align mobile header.
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~183 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~172 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
e473188
to
c0ab1c7
Compare
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Related to https://github.com/Automattic/loop/issues/273
Proposed Changes
We are currently hardcoding the names of user profile feature flags and URLs in various places. To improve maintainability, added
isUserProfileEnabled
andgetUserProfileUrl
util functions.This also helps prevent unwanted typos.
Why are these changes being made?
To improve maintainability and consistency.
Testing Instructions
/read
and verify author profile links are working as expected.Pre-merge Checklist