-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reader: Update author avatar links with user profiles url #98334
base: trunk
Are you sure you want to change the base?
Conversation
This reverts commit ac9f207.
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~90 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~87 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added comments for easier review.
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well and everything is behind the flag. 👍
Thanks for approving the PR. Planning to merge this after #98406 (if there is an agreement) |
Related to https://github.com/Automattic/loop/issues/273
Proposed Changes
The update enables links to author profiles throughout the Reader to direct users to individual user profiles instead of the primary site. This functionality is only accessible if the 'reader/user-profile' feature flag is enabled. As part of this change, the following components have been updated:
Post Comment
ReaderAuthorLink
ReaderAvatar
PostTrackback
also refactored to functional component with TypeScript support.Why are these changes being made?
Clicking on an author's name now navigates users directly to their user profile, where they can access detailed information about that author.
Testing Instructions
/read
.Note: There are many areas where it seems like we are displaying "author avatars", but in reality, these are actually site logos.
Pre-merge Checklist