Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader: Update author avatar links with user profiles url #98334

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from

Conversation

mehmoodak
Copy link
Member

@mehmoodak mehmoodak commented Jan 14, 2025

Related to https://github.com/Automattic/loop/issues/273

Proposed Changes

The update enables links to author profiles throughout the Reader to direct users to individual user profiles instead of the primary site. This functionality is only accessible if the 'reader/user-profile' feature flag is enabled. As part of this change, the following components have been updated:

  • Post Comment
  • ReaderAuthorLink
  • ReaderAvatar
  • PostTrackback also refactored to functional component with TypeScript support.

Why are these changes being made?

Clicking on an author's name now navigates users directly to their user profile, where they can access detailed information about that author.

Testing Instructions

  • Go to /read.
  • From sidebar navigate to different screens Recent, Discover, Likes, Conversation, Lists, Tags and Post Detail page.
  • Verify that every appearance of the author navigates to User Profile page if the flag is enabled.

Note: There are many areas where it seems like we are displaying "author avatars", but in reality, these are actually site logos.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@mehmoodak mehmoodak self-assigned this Jan 14, 2025
@matticbot
Copy link
Contributor

matticbot commented Jan 14, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~90 bytes added 📈 [gzipped])

name                             parsed_size           gzip_size
write-flow                            +363 B  (+0.0%)      +90 B  (+0.0%)
reader                                +363 B  (+0.0%)      +90 B  (+0.0%)
plugins                               +363 B  (+0.0%)      +90 B  (+0.0%)
link-in-bio-tld-flow                  +363 B  (+0.0%)      +90 B  (+0.0%)
jetpack-cloud-plugin-management       +363 B  (+0.0%)      +90 B  (+0.0%)
home                                  +363 B  (+0.0%)      +90 B  (+0.0%)
build-flow                            +363 B  (+0.0%)      +90 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~87 bytes added 📈 [gzipped])

name                                                 parsed_size           gzip_size
async-load-calypso-components-web-preview-component       +363 B  (+0.1%)      +90 B  (+0.1%)
async-load-design-blocks                                  +327 B  (+0.0%)      +87 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Member Author

@mehmoodak mehmoodak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comments for easier review.

client/blocks/comments/post-trackback.jsx Show resolved Hide resolved
client/blocks/reader-avatar/README.md Show resolved Hide resolved
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug loop-273/update-avatar-links on your sandbox.

@mehmoodak mehmoodak marked this pull request as ready for review January 14, 2025 13:13
@mehmoodak mehmoodak requested a review from a team as a code owner January 14, 2025 13:13
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 14, 2025
Copy link
Member

@DustyReagan DustyReagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well and everything is behind the flag. 👍

@mehmoodak
Copy link
Member Author

Thanks for approving the PR. Planning to merge this after #98406 (if there is an agreement)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants