Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats: Override the query period for custom ranges on Summary pages #98328

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

a8ck3n
Copy link
Contributor

@a8ck3n a8ck3n commented Jan 14, 2025

Related to:

https://github.com/Automattic/jpop-issues/issues/9461

Proposed Changes

If a Summary page is dealing with a custom date range, override the period value so the results match those shown on the Traffic page. ie: We want a summarized day query for the number of days requested. We do not want week, month, or other period-based results.

Why are these changes being made?

Without these changes, the Summary pages for authors, clicks, posts, referrers, & videos show results that do not match those shown on the Traffic page.

Testing Instructions

  • Visit the Traffic page.
  • Set a custom range that of more than 30 days. This should cause the period to automatically update from Days to Weeks. If not, pick Weeks as the period.
  • Pick a module (like Authors) and note the results.
  • Click the "View all" link for the module.
  • Confirm the results on the Summary page match those from the Traffic page.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@a8ck3n a8ck3n self-assigned this Jan 14, 2025
@a8ck3n a8ck3n added the [Feature] Stats Everything related to our analytics product at /stats/ label Jan 14, 2025
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • odyssey-stats
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/stats-update-summary-queries on your sandbox.

@a8ck3n a8ck3n requested a review from a team January 14, 2025 10:56
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 14, 2025
@a8ck3n a8ck3n marked this pull request as ready for review January 14, 2025 10:56
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Async-loaded Components (~7 bytes added 📈 [gzipped])

name                                       parsed_size           gzip_size
async-load-calypso-my-sites-stats-summary        +15 B  (+0.0%)       +7 B  (+0.1%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@kangzj kangzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix makes sense to me and it works well 👍

@kangzj kangzj merged commit b818924 into trunk Jan 14, 2025
15 checks passed
@kangzj kangzj deleted the fix/stats-update-summary-queries branch January 14, 2025 22:51
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Stats Everything related to our analytics product at /stats/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants