Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assisted Migration: Add Help link on the top right corner #98233

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

valterlorran
Copy link
Contributor

@valterlorran valterlorran commented Jan 10, 2025

Related to #

Proposed Changes

  • Adds the Help link in the top right corner on the Site Analyze step. Clicking on the button should create the ticket for the user.

Captura de Tela 2025-01-13 às 19 16 14

Why are these changes being made?

  • I realized that we are missing the Help link on the top right corner, as the design suggested: F8foKv974Gc5dTHSh0i0Wo-fi-648_7452

Testing Instructions

  • Use the Calypso Live link below
  • Go through the Migration flow until you reach the "Tell us about your WordPress site" step
  • Note the right in the top right corner and click on the link.
  • You should be redirected to the Instruction page, and the ZD ticket should be created

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@valterlorran valterlorran requested a review from a team January 10, 2025 20:57
@valterlorran valterlorran self-assigned this Jan 10, 2025
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 10, 2025
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@gabrielcaires
Copy link
Contributor

@valterlorran Do we need to remove the other help link above the button? It seems duplicated and it is not on the figma file.

import { Button } from '@wordpress/components';
import { translate } from 'i18n-calypso';

export const NeedHelpLink = ( { onSkip }: { onSkip: () => void } ) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't the parameter be called onAction or onHelpLinkClicked or something along those lines? In the context of a separate component it's not "skipping" it's the main action of the component.

@andres-blanco
Copy link
Contributor

@valterlorran Do we need to remove the other help link above the button? It seems duplicated and it is not on the figma file.

good catch @gabrielcaires

@valterlorran
Copy link
Contributor Author

@andres-blanco, thanks for the feedback. I applied it.

@gabrielcaires, good catch. That's probably from the last iteration. I will remove it. By the way, you mean the link below the submit button, right?

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/need-help-assisted-migration on your sandbox.

@gabrielcaires
Copy link
Contributor

@andres-blanco, thanks for the feedback. I applied it.

@gabrielcaires, good catch. That's probably from the last iteration. I will remove it. By the way, you mean the link below the submit button, right?

yes!

@valterlorran valterlorran force-pushed the add/need-help-assisted-migration branch from 65e5ef1 to ea3fcbe Compare January 14, 2025 17:51
@andres-blanco andres-blanco added the [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging label Jan 14, 2025
@andres-blanco
Copy link
Contributor

we have to wait on translation to deploy this, I've added the string freeze label.

@a8ci18n
Copy link

a8ci18n commented Jan 14, 2025

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17194557

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @valterlorran for including a screenshot in the description! This is really helpful for our translators.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants