-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assisted Migration: Add Help link on the top right corner #98233
base: trunk
Are you sure you want to change the base?
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
@valterlorran Do we need to remove the other help link above the button? It seems duplicated and it is not on the figma file. |
import { Button } from '@wordpress/components'; | ||
import { translate } from 'i18n-calypso'; | ||
|
||
export const NeedHelpLink = ( { onSkip }: { onSkip: () => void } ) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't the parameter be called onAction
or onHelpLinkClicked
or something along those lines? In the context of a separate component it's not "skipping" it's the main action of the component.
good catch @gabrielcaires |
@andres-blanco, thanks for the feedback. I applied it. @gabrielcaires, good catch. That's probably from the last iteration. I will remove it. By the way, you mean the link below the submit button, right? |
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
yes! |
65e5ef1
to
ea3fcbe
Compare
we have to wait on translation to deploy this, I've added the string freeze label. |
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17194557 Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday. Thank you @valterlorran for including a screenshot in the description! This is really helpful for our translators. |
Related to #
Proposed Changes
Why are these changes being made?
Testing Instructions
Pre-merge Checklist