Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domain management: Show the DNS subpage in site context #98208

Open
wants to merge 10 commits into
base: trunk
Choose a base branch
from

Conversation

bogiii
Copy link
Contributor

@bogiii bogiii commented Jan 10, 2025

Closes #97967

Proposed Changes

  • Update method to generate path based on the context

Why are these changes being made?

  • Domains management revamp

Testing Instructions

  • Enable the feature flag by window.sessionStorage.setItem('flags', 'calypso/all-domain-management')
  • Purchase a blog domain and attach a site with it.
  • Now go to calypso.localhost:3000/sites and open this site in flyout
  • Scroll to the bottom and click on the row to open the domain in site context
  • Open the DNS Records section and click on the "Manage" button
  • Check if the screen is rendered in the site-context
Screenshot 2025-01-14 at 19 13 04
  • Enable the feature flag by window.sessionStorage.setItem('flags', 'calypso/all-domain-management')
  • Purchase a blog domain and attach a site with it.
  • Now go to calypso.localhost:3000/sites and open this site in flyout
  • Scroll to the bottom, open the context menu, and select "Manage DNS"
  • Check if you stay in the same context
Screenshot 2025-01-10 at 12 45 25

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

matticbot commented Jan 10, 2025

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/domains-management-email-13 on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented Jan 10, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~41 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
entry-main                   +85 B  (+0.0%)      +22 B  (+0.0%)
entry-login                  +85 B  (+0.0%)      +22 B  (+0.0%)
entry-domains-landing        +85 B  (+0.0%)      +17 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~159 bytes added 📈 [gzipped])

name                  parsed_size           gzip_size
hosting                    +425 B  (+0.0%)     +136 B  (+0.0%)
domains                    +256 B  (+0.0%)     +110 B  (+0.0%)
site-overview               +91 B  (+0.0%)      +29 B  (+0.0%)
update-design-flow          +85 B  (+0.0%)      +22 B  (+0.0%)
link-in-bio-tld-flow        +85 B  (+0.0%)      +22 B  (+0.0%)
copy-site-flow              +85 B  (+0.0%)      +22 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~69 bytes added 📈 [gzipped])

name                                                                              parsed_size           gzip_size
async-load-signup-steps-page-picker                                                     +85 B  (+0.0%)      +22 B  (+0.0%)
async-load-signup-steps-domains                                                         +85 B  (+0.0%)      +23 B  (+0.0%)
async-load-purchase-modal-wrapper                                                       +85 B  (+0.0%)      +22 B  (+0.0%)
async-load-my-sites-checkout-purchase-modal-is-eligible-for-one-click-checkou...        +85 B  (+0.0%)      +22 B  (+0.0%)
async-load-calypso-my-sites-checkout-modal                                              +85 B  (+0.0%)      +24 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@bogiii bogiii changed the title Domain management: Domain management: Fix manage DNS path Jan 10, 2025
@bogiii bogiii self-assigned this Jan 10, 2025
@bogiii bogiii marked this pull request as ready for review January 10, 2025 11:47
@bogiii bogiii requested a review from a team January 10, 2025 13:00
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 10, 2025
@bogiii bogiii force-pushed the update/domains-management-email-13 branch from 2e759ab to 415cfd1 Compare January 13, 2025 11:39
@bogiii bogiii changed the title Domain management: Fix manage DNS path Domain management: Show the DNS subpage in site context Jan 13, 2025
Copy link
Contributor

@phcp phcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall works great, just noticed that the breadcrumb is missing the "DNS records" item.

image

@@ -35,6 +35,7 @@ interface DomainsTableRowActionsProps {
canSetPrimaryDomainForSite: boolean;
isSiteOnFreePlan: boolean;
isSimpleSite: boolean;
isHostingOverview?: boolean;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing for this specific PR, but does this variable refer to the same thing as the inSiteContext? If that is the case, I think we should converge to use the same name. isHostingOverview seems more readable to me.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that refers to the hosting-overview context, which is indeed a site context.

@phcp
Copy link
Contributor

phcp commented Jan 13, 2025

Another thing I noticed is that the tabs remain displayed on the subpage, which is not expected in the design of Figma.

@bogiii bogiii force-pushed the update/domains-management-email-13 branch from 6acb3c6 to 152f9f4 Compare January 14, 2025 17:53
@bogiii bogiii requested a review from phcp January 14, 2025 18:18
Copy link
Contributor

@Imran92 Imran92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bogiii 👋 There is a rebase conflict, can you kindly fix that to unblock the reviewing? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Site-context: show the DNS Management sub-page
4 participants