-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Domain management: Show the DNS subpage in site context #98208
base: trunk
Are you sure you want to change the base?
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~41 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~159 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~69 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
2e759ab
to
415cfd1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -35,6 +35,7 @@ interface DomainsTableRowActionsProps { | |||
canSetPrimaryDomainForSite: boolean; | |||
isSiteOnFreePlan: boolean; | |||
isSimpleSite: boolean; | |||
isHostingOverview?: boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing for this specific PR, but does this variable refer to the same thing as the inSiteContext
? If that is the case, I think we should converge to use the same name. isHostingOverview
seems more readable to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that refers to the hosting-overview
context, which is indeed a site context.
Another thing I noticed is that the tabs remain displayed on the subpage, which is not expected in the design of Figma. |
6acb3c6
to
152f9f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @bogiii 👋 There is a rebase conflict, can you kindly fix that to unblock the reviewing? Thanks!
Closes #97967
Proposed Changes
Why are these changes being made?
Testing Instructions
window.sessionStorage.setItem('flags', 'calypso/all-domain-management')
window.sessionStorage.setItem('flags', 'calypso/all-domain-management')
calypso.localhost:3000/sites
and open this site in flyoutPre-merge Checklist