Subscriber: Remove the subscriber from both followers and email followers

[arthur791004]

Related to Automattic/jetpack#40850

Proposed Changes

• Remove the subscriber from both followers and email followers. See Subscriptions - not possible to remove a subscriber. jetpack#40850 (comment)

Why are these changes being made?

• The subscribers may not be removed

Testing Instructions

• Go to your site
• Add a subscriber
• Remove a subscriber
• Make sure the subscriber can be removed successfully

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-129735

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-129735&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-129735&env=a8c-for-agencies

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~39 bytes added 📈 [gzipped])

name         parsed_size           gzip_size
subscribers       +175 B  (+0.0%)      +39 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~46 bytes added 📈 [gzipped])

name                                                 parsed_size           gzip_size
async-load-calypso-my-sites-stats-pages-subscribers       +175 B  (+0.1%)      +46 B  (+0.1%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• notifications
• wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/remove-subscribers on your sandbox.

[arcangelini]

I think this is a good start and will fix the issue at hand. I understand there may be better ways of addressing this (discussed in the issue thread), but this is the best option at the moment and helps us give a better experience to the users.

I tested this with a normal user and had no problems at all. I also tested this with one of the users having issues unsubscribing and it resolved for them.

🚀🚀🚀

[arcangelini]

@arthur791004 I hope you don't mind but I pushed a commit to further fix the issue. When I tested from my personal site I had no problem at all, but when I tested from a site that had a stuck subscriber it still did not work. I believe it was being caused by the initial API response from subscriber.user_id which was an error and stopped everything. Wrapping it in a try/catch and only erroring out conditionally resolved the issue and allowed the subscriber to be removed. I am pretty sure the logic is correct but maybe double check me : )

( e as ApiResponseError )?.error !== 'not_found' && subscriber.subscription_id