Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Migration: Indicate that you own the plan on the Migrate vs Import step #98017

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from

Conversation

gabrielcaires
Copy link
Contributor

@gabrielcaires gabrielcaires commented Jan 7, 2025

Closes #97740

Proposed Changes

  • Refactor to make the copy decision more explicitly
  • Update logic to show the Requires Business plan based on whether it is possible to install plugins instead of checking the existing plan name.

Screenhots

  1. Free site
    CleanShot 2025-01-07 at 12 04 39@2x

The site already has the business plan
CleanShot 2025-01-07 at 11 28 03@2x

E-commerce plan
CleanShot 2025-01-07 at 11 58 52@2x

Testing Instructions

Free site

  • Go to /setup/hosted-site-migration
  • Create a new site (free plan)
  • Follow all steps until the Import or Migrate step
  • Check if you can see the label (Screenshot 1)

business plan site

  • Create a new site using a business plan
  • Go to /setup/hosted-site-migration
  • Select the site using the business plan
  • Follow all steps until the Import or Migrate step
  • Check if you can see the label (Screenshot 2)

ecommerce plan site

  • Create a new site using a ecommerce plan
  • Go to /setup/hosted-site-migration
  • Select the site using the ecommerce plan
  • Follow all steps until the Import or Migrate step
  • Check if you can see the label (Screenshot 3)

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

matticbot commented Jan 7, 2025

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/show-plan-is-included on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented Jan 7, 2025

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@gabrielcaires gabrielcaires marked this pull request as ready for review January 7, 2025 12:05
@gabrielcaires gabrielcaires added [Feature] Site Migration Features related to site migrations to WPcom [Type] Bug labels Jan 7, 2025
@gabrielcaires gabrielcaires self-assigned this Jan 7, 2025
@gabrielcaires gabrielcaires requested a review from a team January 7, 2025 12:10
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 7, 2025
@gabrielcaires gabrielcaires changed the title Refactor component to centralize copy logic Site Migration: Indicate that you own the plan on the Migrate vs Import step Jan 7, 2025
@gabrielcaires gabrielcaires force-pushed the update/show-plan-is-included branch from 3dd77c0 to d7ed236 Compare January 13, 2025 11:59
@andres-blanco andres-blanco added the [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging label Jan 14, 2025
},
selected: true,
},
{
label: translate( 'Import content only' ),
description: translate( 'Import just posts, pages, comments and media.' ),
description: translate( 'Import posts, pages, comments, and media only.' ),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this copy changed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Migration Features related to site migrations to WPcom [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging [Type] Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration flow: Indicate that you own the plan on the Migrate vs Import step
3 participants