Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection state updated after reconnect #294

Merged

Conversation

ClintHaerinck
Copy link
Contributor

The pull request for issue #293

@codecov-io
Copy link

codecov-io commented Feb 10, 2020

Codecov Report

Merging #294 into master will decrease coverage by 0.48%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #294      +/-   ##
==========================================
- Coverage   94.87%   94.38%   -0.49%     
==========================================
  Files           6        6              
  Lines         390      392       +2     
==========================================
  Hits          370      370              
- Misses         20       22       +2
Impacted Files Coverage Δ
lib/manager.js 94.2% <50%> (-1.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fe6dd4...ccf3c8d. Read the comment docs.

Copy link
Collaborator

@mathieudutour mathieudutour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mathieudutour mathieudutour merged commit a61b0cf into Automattic:master Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants