-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: Add --use-version
option to jetpack release
#41095
Conversation
Many of the various commands run by `jetpack release` can take an option for a specific version. Allow this to be done. In particular, this will be useful for doing the 1.0.0 release of a package.
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worked for me.
I'll note in general it's a bit confusing that there are sometimes positional args for version, and now there's a --use-version
flag. And then we have promptForVersion
, which sets version
, and we have version_type
...
Yeah, possibly some of that could be cleaned up. Although I don't think |
Indeed, I was misreading it. :^) |
Proposed changes:
Many of the various commands run by
jetpack release
can take an option for a specific version. Allow this to be done.In particular, this will be useful for doing the 1.0.0 release of a package.
Other information:
Jetpack product discussion
p1736961528818299/1736959724.475999-slack-C05Q5HSS013
Does this pull request change what data or activity we track or use?
No
Testing instructions:
--use-version
option to see if they behave appropriately.