-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forms: update copies from title case to sentence case and add translations #41086
base: trunk
Are you sure you want to change the base?
Conversation
Are you an Automattician? The PR will need to be tested on WordPress.com. This comment will be updated with testing instructions as soon the build is complete. |
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! |
@@ -401,7 +404,7 @@ export const childBlocks = [ | |||
...FieldDefaults.attributes, | |||
label: { | |||
type: 'string', | |||
default: 'Email', | |||
default: __( 'Email', 'jetpack-forms' ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Automattic/jetpack-vulcan any reason why default label values might've been untranslated? E.g. deprecation warnings between switching site locale?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No idea. I can't think of any reasons why it wouldn't be the case in a JS file.
While lots of other things in Gutenberg and WP.com/Jetpack are sentence case, block names seem to still be title case: @jasmussen I've seen you active with title case/sentence case work — do you we have documented guidance on how to go about copy in editor? |
Thanks for the ping, excellent PR. The guidance for core, to the best of my recollection (though CC: @jameskoster and @auareyou for design system guidance, and @Automattic/dotcom-design for good measure), is that for all UI, we use sentence case with capital proper nouns. Example: Sentence case:
Capitalized proper nouns:
I recall also discussing this with @talldan, in case he has additional context. |
Beyond that rule, though, I just want to acknowledge that there are a ton of inconsistencies where that rule is not yet properly applied. |
Gotha, so your advice is to go ahead sentence casing everything, including block names, even if it might, on the surface, create inconsistencies with some Gutenberg UIs. |
Not specifically, no. I'd say to apply it as a general rule to everything we build in general, menus, buttons, UIs, dropdowns, buttons and so on. I wouldn't hack/override anything, and we might even want to make an exception on block names until those are more consistent there, or just decide that "Media & Text" is the title of a block, and therefore fully a proper noun. Similarly, "Google Photos" would be a proper noun, though in the case that I fixed recently, "Pexels free photos" would be sentence case. |
It's by no means ideal, but I'd lean towards aiming for contextual consistency in the short term. Gutenberg tends to favor sentence case while wp-admin favors title case. So if it's an editor UI use sentence case, and if it's a wp-admin UI use title case. If it's a string that can appear in either context then sentence case probably makes sense, if we assume Gutenberg better represents the general design vision. |
Next up is looking into E2E tests in Jetpack and Calypso as this introduces a lot of changes that likely throw those tests off. |
I don't have any, other than it's difficult to know what's right, but most of the time consistency is the best option. Block names are difficult. In general they are capitalized as nouns, but might be different when used in a sentence. One situation I remember was 'Manage Reusable Blocks' vs. 'Manage reusable blocks'. I think there are also still inconsistencies as Joen mentions, like in the editor Options menu 'Welcome Guide' is inconsistent with everything else (e.g. 'Code editor' or 'Distraction free'). Also lots of the tabs/tooltips/buttons in the editor are inconsistent with that menu - 'Document Overview', 'List View', Block Inserter'. I think in general the trend has been towards sentence casing most things in the editor, so those are probably wrong. 😄 |
Proposed changes:
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions: