-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WooCommerce Analytics] Add woocomerceanalytics_session #41085
base: trunk
Are you sure you want to change the base?
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! |
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Fixes and issue with the way we set the cookie for storing woocomerceanalytics_session that created cache issues.
In this PR we do set the cookie using JS to avoid those cache misses.
Proposed changes:
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
See how it was before when the set cookie was set in PHP headers
Note:
Mybe you want to quickly push the plugin to a live JN site without waiting for the builds. This rsync wrapper knows which files to send and not send.
Rsync the Jetpack plugin to server destination:
jetpack rsync jetpack [email protected]:/home/path/to/wp-content/plugins
Find the command in your JN site
Notice also that for track to happen USage TRcking should be enabled in WoCommerce -> Settings -> Advanced -> WooCommerce.com -> "Allow usage tracking"
Also JP (or WPCOM) should be connected