Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My Jetpack: Add red bubble and notice when paid plan needs plugin install or activation. #41013

Open
wants to merge 8 commits into
base: trunk
Choose a base branch
from

Conversation

elliottprogrammer
Copy link
Contributor

@elliottprogrammer elliottprogrammer commented Jan 14, 2025

This PR adds a red-bubble and notice-banner when the site detects that a paid plan provides features to a plugin (or multiple plugins) that are not installed and/or activated. The notice recommends that the plugin(s) should be installed and/or activated and provides a CTA to install and activate all in one click.
To summarize, basically it adds a red-bubble and notice for missing plugins that are needed for purchased products to work. See screenshot:

Screen Shot 2025-01-16 at 10 48 54

Fixes: https://github.com/Automattic/jetpack-roadmap/issues/1393

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Project Thread - pbNhbs-bJN-p2
Github Task - https://github.com/Automattic/jetpack-roadmap/issues/1393

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • It's best to test this PR with a Jurassic Ninja site (using the Jetpack Beta plugin), as opposed to a local dev site (because a local dev site already has all Jetpack plugins installed via the nature of the monorepo).
  • Connect Jetpack (both site and user).
  • Purchase the Jetpack Complete plan for the site.
  • In My Jetpack, you should see a red-bubble and notice, stating Some plugins need installation. (See screenshot above in the description ⤴️)
  • Verify all the links in the notice. The "Jetpack Complete paid subscription" link should point to the Calypso green purchases Complete subscription page. The Jetpack Boost and Jetpack CRM plugin links should point to their respective plugins page on wordpress.org
  • Click the "install and activate plugins in one click" CTA. The CTA loading text should say, "Installing and activating plugins...".
  • After a few moments (after the plugins are installed and activated) the banner should disappear.
  • Verify that the Jetpack Boost and CRM plugins have been installed and activated.
  • If desired, you can try other paid plan with a missing (or un-activated) plugin(s) combinations. For example, with only a standalone plugin installed, (the main Jetpack plugin Not installed), purchase a Jetpack AI plan. Verify a red bubble and notice appear stating that the Jetpack plugin should be installed in order for Jetpack AI to work properly.

@elliottprogrammer elliottprogrammer self-assigned this Jan 14, 2025
Copy link
Contributor

github-actions bot commented Jan 14, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the add/mj-red-bubble-notice-when-plugins-need-installed branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack add/mj-red-bubble-notice-when-plugins-need-installed
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

github-actions bot commented Jan 14, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • 🔴 Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Jan 14, 2025
@elliottprogrammer elliottprogrammer requested a review from a team January 16, 2025 19:48
@elliottprogrammer elliottprogrammer added [Status] Needs Team Review and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Jan 16, 2025
@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] My Jetpack [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! [Status] Needs Team Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant