Release WP Job Manager 2.4.0 #2841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please perform the following tests with the built package in a new installation before publishing:
|
fjorgemota
reviewed
Jul 31, 2024
There was a problem hiding this comment.
Hey. This is looking good!
I left one question for the CSS change. :)
One thing I'm wondering here: Shouldn't this be 2.3.1? Which new features are we introducing here?
Also, shouldn't we update the class \WP_Job_Manager\Admin\Release_Notice to reflect the news on wp-admin maybe?
fjorgemota
approved these changes
Aug 8, 2024
There was a problem hiding this comment.
I discussed with @yscik on Slack and we found out that:
- It is better to be 2.4.0 on this case because we're removing IE11 support, so 2.3.1 will not highlight this
- The release notes on the notice doesn't need to be changed, because we're mostly fixing issues
Hence, I'm approving this PR. Let's release this!
|
✅ WP Job Manager 2.4.0 release created! |
1 similar comment
|
✅ WP Job Manager 2.4.0 release created! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Merging this PR will build and publish the new version automatically as a GitHub release, then deploy the new version on the WordPress.org plugin repository.
WP Job Manager 2.4.0
Note
These release notes between the two lines will be the final changelog entry for the release. Edit them freely here before merging.
Release Notes
Release
Note
Click 'Ready for Review', ping the team, review the PR and merge. Upon merging, automation will: