-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small fixes to actions and release script #2646
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changelog generation code looks good 👍
I'm not entirely sure what the actions/checkout@v4
is so I'm reluctant to approve the PR. Hoping someone else familiar with the release script can look at it.
Also, when running the release script I got the following error, but it also happened on Trunk so I think it might just be my environment and not this PR.
Thank you for taking a look @jgcaruso!
Tried it again and it didn't happen. I would start debugging by running the pot build command individually:
This action checks out the code. It's a common first step before doing the rest of the stuff like building, running tests etc. |
So running that gives me This is probably just because I'm a fresh install (and maybe didn't real all of the documentation 😅 ), but I wonder if some dependencies should be added, and maybe the
Oh so its a github actions specific thing? Cool! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested well!
Once I installed wp-cli
globally and ran composer install
the release script worked and created the release PR #2656
Changes Proposed in this Pull Request
Testing Instructions