Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes to actions and release script #2646

Merged
merged 2 commits into from
Nov 24, 2023
Merged

Conversation

gikaragia
Copy link
Contributor

@gikaragia gikaragia commented Nov 20, 2023

Changes Proposed in this Pull Request

  • Updates actions/checkout to v4 to avoid some warnings
  • Adds a default release note 'Updated plugin headers' when the release notes are empty.

Testing Instructions

@gikaragia gikaragia changed the title Update to checkout v4 Small fixes to actions and release script Nov 20, 2023
@gikaragia gikaragia self-assigned this Nov 20, 2023
@gikaragia gikaragia added the [Type] Maintenance Changes to non-production files label Nov 20, 2023
Copy link

@jgcaruso jgcaruso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog generation code looks good 👍

I'm not entirely sure what the actions/checkout@v4 is so I'm reluctant to approve the PR. Hoping someone else familiar with the release script can look at it.

Also, when running the release script I got the following error, but it also happened on Trunk so I think it might just be my environment and not this PR.
SCR-20231122-npqn

@gikaragia
Copy link
Contributor Author

gikaragia commented Nov 23, 2023

Thank you for taking a look @jgcaruso!

I got the following error,

Tried it again and it didn't happen. I would start debugging by running the pot build command individually: npm run i18n:build

I'm not entirely sure what the actions/checkout@v4 is

This action checks out the code. It's a common first step before doing the rest of the stuff like building, running tests etc.
The version upgrade should be backwards compatible. I did the update because v2 uses node 12 IIRC and this version is deprecated by Github. So it just uses node 16 anyway and prints a warning. I did a similar change for wpjm-addons here.

@jgcaruso
Copy link

jgcaruso commented Nov 23, 2023

I would start debugging by running the pot build command individually: npm run i18n:build

So running that gives me wp: command not found

This is probably just because I'm a fresh install (and maybe didn't real all of the documentation 😅 ), but I wonder if some dependencies should be added, and maybe the i18n:build should be part of the release? Or is it mentioned as a pre-release step in some release documentation, so it doesn't need to be automated?

This action checks out the code. It's a common first step before doing the rest of the stuff like building, running tests etc.

Oh so its a github actions specific thing? Cool!

@gikaragia
Copy link
Contributor Author

gikaragia commented Nov 23, 2023

Ah yes @jgcaruso! You need WP-cli to be installed and globally available for this command to run. I'll add this to the release documentation.

Copy link

@jgcaruso jgcaruso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested well!

Once I installed wp-cli globally and ran composer install the release script worked and created the release PR #2656

@gikaragia gikaragia merged commit 465d79b into trunk Nov 24, 2023
7 checks passed
@gikaragia gikaragia deleted the fix/release-issues branch November 24, 2023 08:08
@yscik yscik added this to the 2.2.0 milestone Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Maintenance Changes to non-production files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants