-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Style settings page header #2641
Conversation
Looks great @yscik! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @yscik !
Added a few small escaping things.
I also found one small issue - which I think are actually not new but might be good to address?
When in a mobile view, if you click on something like "Job Submission" - there's a margin-bottom: 1px
which is pushing the other elements below it:
This CSS seems to fix it:
.nav-tab.nav-tab-active {
margin-bottom: 0;
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good! 🎉
Fixes 163-gh-Automattic/wpjm-addons
Also moved the Save button to the header, because it can be hard to find/remember sometimes when the page is long.
Changes Proposed in this Pull Request
..-addons
URLTesting Instructions
Release Notes
Screenshot / Video