Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style settings page header #2641

Merged
merged 6 commits into from
Nov 28, 2023
Merged

Style settings page header #2641

merged 6 commits into from
Nov 28, 2023

Conversation

yscik
Copy link
Contributor

@yscik yscik commented Nov 17, 2023

Fixes 163-gh-Automattic/wpjm-addons

Also moved the Save button to the header, because it can be hard to find/remember sometimes when the page is long.

  • Added the styled header to the Marketplace page too.

Changes Proposed in this Pull Request

  • Add a header with logo to the Settings and Marketplace changes
  • Tweak some colors and spacing, set max width
  • Move the Save Changes button to the header, make it change color when there are changes to save
  • Fix some scroll jumping
  • Fix search in the Marketplace page going to the old ..-addons URL
  • Update the outdated lost license link in the License page

Testing Instructions

  • Open the Job Manager → Settings page, click around, change some settings, make sure everything works right
  • Also check out the Job Manager → Marketplace page

Release Notes

  • Update design for settings and marketplace pages

Screenshot / Video

image

image


Plugin build for 0b81e90
📦 Download plugin zip
▶️ Open in playground

@yscik yscik self-assigned this Nov 17, 2023
@masteradhoc
Copy link
Contributor

Looks great @yscik!

Copy link
Member

@mikeyarce mikeyarce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @yscik !

Added a few small escaping things.

I also found one small issue - which I think are actually not new but might be good to address?

When in a mobile view, if you click on something like "Job Submission" - there's a margin-bottom: 1px which is pushing the other elements below it:
CleanShot 2023-11-17 at 11 07 29@2x

This CSS seems to fix it:

.nav-tab.nav-tab-active {
  margin-bottom: 0;
}

includes/admin/class-wp-job-manager-addons.php Outdated Show resolved Hide resolved
includes/admin/class-wp-job-manager-settings.php Outdated Show resolved Hide resolved
includes/admin/class-wp-job-manager-settings.php Outdated Show resolved Hide resolved
@yscik
Copy link
Contributor Author

yscik commented Nov 20, 2023

Thanks! Improved the escaping and did some fixes for mobile, with smaller logo, non-sticky header and a save button in the bottom.

image

@yscik yscik requested a review from mikeyarce November 20, 2023 13:05
Copy link
Member

@mikeyarce mikeyarce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good! 🎉

@yscik yscik added this to the 2.2.0 milestone Nov 28, 2023
@yscik yscik merged commit 3ed9ecd into trunk Nov 28, 2023
7 checks passed
@yscik yscik deleted the update/settings-design branch November 28, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants