Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change string positions to listings / Clarify "Archives" Language in Expired Listings / Filled Positions Settings #2634

Merged
merged 8 commits into from
Nov 16, 2023
Merged

Change string positions to listings / Clarify "Archives" Language in Expired Listings / Filled Positions Settings #2634

merged 8 commits into from
Nov 16, 2023

Conversation

masteradhoc
Copy link
Contributor

@masteradhoc masteradhoc commented Nov 11, 2023 •
edited
Loading

Fixes #2491, Fixes #2492

Changes Proposed in this Pull Request

  • Change appearance of string positions to listings

Testing Instructions

  • Go through all screens and check the appearance of positions and check if they are changed to listings after the PR

Release Notes

  • Change positions to listings for consistency

@masteradhoc masteradhoc marked this pull request as ready for review November 11, 2023 20:00
@masteradhoc masteradhoc mentioned this pull request Nov 13, 2023
Closed
@masteradhoc masteradhoc changed the title Change string positions to listings Change string positions to listings / Clarify "Archives" Language in Expired Listings / Filled Positions Settings Nov 13, 2023
@gikaragia
Copy link
Contributor

Thank you for the contribution @masteradhoc, looks good overall! I needed to do some changes and I raised another PR here.

@gikaragia gikaragia merged commit 31fb444 into Automattic:trunk Nov 16, 2023
1 of 7 checks passed
@masteradhoc
Copy link
Contributor Author

Thanks @gkaragia!

@masteradhoc masteradhoc deleted the positions-listings branch November 16, 2023 18:43
@gikaragia gikaragia modified the milestone: 2.0.0 Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gikaragia gikaragia gikaragia left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@masteradhoc @gikaragia