-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cert.pem #466
base: future-tcs
Are you sure you want to change the base?
Update cert.pem #466
Conversation
hmmm... considering the history of this repo, the fact that those guidelines were last updated 6 years ago, and that the future-tcs branch is 3 commits behind master; i would be confused as to where to put this PR as well. that said, i have tested this PR against the sandbox as well as production environment, and found them both to be working. on the production environment, i tested an authorize as well as a void transaction. i am curious if anyone else has tested this against the live environment. many thanks to @demeritcowboy for doing this! |
Thanks for testing. Although you shouldn't see any difference until Oct 23 since the servers are still using the Entrust certificate. I contacted their support to try to clarify the timing to see if it could be tested in the sandbox before the production servers switch, but I'm sure the person at the other end was a bot and didn't really understand what I was asking. Actually, looking closer this PR may not even be needed since the Digicert Global Root G2 is even in the older cert.pem file, but it's not a bad idea to keep the file updated. |
@demeritcowboy It does look like the Digicert Global Root G2 cert is included and the best one however according to Authnets documentation it says "Download the root and intermediate certificates from DigiCert" -- Do you think not having the intermediate certificate will cause an issue? |
It might depend on your integration if it needs the intermediate cert or not. Usually the standard root certificates file is sufficient. |
Note, I verified this matches the current root certificates bundle distributed by curl.se at https://curl.se/docs/caextract.html (per the header). It seems to me that a potential point of improvement would be to reduce the list of certificates to just those actually used by Authorize.net: Entrust and DigiCert. But that's not something they've done to date, and it's easier to maintain this way, so I'm sure this is fine to merge as is. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Matches the current cacert.pem bundle distributed at https://curl.se/docs/caextract.html (dated Tue Sep 24 03:12:04 2024 GMT).
…here: AuthorizeNet/sdk-php#466 To take affect October 23 for testing and October 24 for production.
Addresses #465
The guidelines say to put PRs against the future branch so that's where I've put it.