fixing setup.py for pip install #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 137 137
=========================================
Hits 137 137 ☔ View full report in Codecov by Sentry. |
added 2 commits
November 22, 2022 09:55
|
Kudos, SonarCloud Quality Gate passed!
|
|
Any updates? |
laudmt
requested changes
Sep 28, 2024
| @@ -19,7 +19,7 @@ | |||
| long_description_content_type="text/markdown", | |||
| include_package_data=True, | |||
| url="https://github.com/Aura-healthcare/ecg_qc", | |||
| packages=setuptools.find_packages("ecg_qc/*", exclude=["tests"]), | |||
| packages=['ecg_qc'], | |||
There was a problem hiding this comment.
Reopening this after a long time ... Thank you adgilbert for your PR!
Just one comment :
packages=setuptools.find_packages(exclude=["tests"]) would fix and keep the test exclusion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small setup.py fix.
The current version of setup.py will look inside of the ecg_qc for modules whereas we actually want it to install ecg_qc as a module.
Thanks for the nice repo!