Extending SANs DNS entries #170
Open
+47
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please modify this too: https://github.com/AthenZ/k8s-athenz-sia/blob/main/athenz-sia.env |
|
y-myajima
reviewed
Nov 27, 2024
y-myajima
reviewed
Nov 28, 2024
Signed-off-by: myajima <[email protected]>
mlajkim
reviewed
Jan 10, 2025
pkg/config/derived-service-cert.go
Outdated
| @@ -48,6 +49,7 @@ func (idCfg *IdentityConfig) derivedServiceCertConfig() error { | |||
| Provider: "", | |||
| AthenzDomainName: "", | |||
| AthenzServiceName: "", | |||
| CertExtraSANDNSs: []string{}, | |||
There was a problem hiding this comment.
I think you should change in a way so that you can set the following in pkg/certificate/identity.go:
SANs: util.SubjectAlternateNames{
DNSNames: idCfg.ServiceCert.CopperArgos.Sans,
URIs: []url.URL{*spiffeURI},
},introducing CertExtraSANDNSs under CopperArgosMode doesn't look clean to me.
There was a problem hiding this comment.
@mlajkim To simplify the PR, could you make the PR against ctyano:tatyano, so that we can include the both of this original PR and your proposal?
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This Pull Requests adds capability to set additional Subjct Alternative Names DNS field to the identity certificates issued by SIA.
Currently, the implementation restricts to have only certain syntaxes in SANs DNS and this restriction is limiting the use of the identity certificates for server certificate purposes.
This enhancement will bring more flexibility to add SANs DNS that matches their actual DNS domains.
For the security perspective it is recommended to always verify the SANs DNS in CSR by the instance identity provider.
Assignees
Assigneesis setType of changes
labelsof the following that fits:enhancement: New FeatureFlags
Checklist
[skip ci]/[ci skip]/[no ci]/[skip actions]/[actions skip]in the PR title if necessaryChecklist for maintainer
Squash and merge[skip ci]/[ci skip]/[no ci]/[skip actions]/[actions skip]