ui search capability to include services #2832
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtjomsPorss
force-pushed
the
search-services
branch
2 times, most recently
from
ac5da73 to
dc3db16
Compare
Signed-off-by: aporss <[email protected]>
ArtjomsPorss
force-pushed
the
search-services
branch
from
d400b98 to
af8f810
Compare
chandrasekhar1996
suggested changes
Jan 13, 2025
There was a problem hiding this comment.
- We should indicate to the the user that the search results being shown is partial. (The search results is partial when serviceMatchCount field is set.) One way to do that can be to show it in Search results header below
- The backend API has the capability to filter results based on domain name as well. Can you confirm if this story/PR was also meant to add support for that in UI? IIRC users can give "athenz:zms" as search term then UI can make search call with domain name set to athenz and service to zms
| req.clients.zms.searchServiceIdentities(params, function (err, data) { | ||
| if (!err && Array.isArray(data.list)) { | ||
| data.list.sort((a, b) => { | ||
| debug(a.name, b.name); |
There was a problem hiding this comment.
remove in subsequent PR
There was a problem hiding this comment.
regarding point 2 - services search accepts partial name of the service, without the domain name
There was a problem hiding this comment.
will make change regarding point 1
There was a problem hiding this comment.
for point 2, the scenario I was thinking of is if searching for a service returns more than 100(default limit) results then user will never be able to use UI for search if the result is after top 100 even though the user may know the domain name which will help further narrow it down.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
UI search capability to include services
Contribution Checklist: