Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exploring ES modules support #1

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Exploring ES modules support #1

wants to merge 2 commits into from

Conversation

Arxcis
Copy link
Owner

@Arxcis Arxcis commented Oct 16, 2020 •
edited
Loading

Why?

Progress

  • So far a rudimentary, non-functional conversion has been done, just to have something to look at.
  • Most of the conversion is very easy to do, as the javascript/net/grpc/web/-files already are strictly modularized. They map well to esm.
  • There has been zero attempt at being backwards-compatible with legacy module systems.

Uanswered questions?

  • How should references to other packages, like goog.net.Xhrlo, be resolved? CDN? Relative paths? Make a bundle-esm tool?
  • How can we ramain backwards-compatible with legacy module systems?

@Arxcis
Transform grpc/web/*.js files to esm
3c7442b 
- Except references to external modules,
I don't know how to resolve those yet.
- Add index.js file as a module export file
Arxcis
Arxcis commented Oct 16, 2020
View reviewed changes
Copy link
Owner Author

@Arxcis Arxcis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO - Figure out how to resolve these modules in an esm-friendly manner

  • "goog.net.streams.NodeReadableStream"
  • "goog.net.XhrIo"
  • "goog.net.rpc.HttpCors"
  • "goog.net.ErrorCode"
  • "goog.net.EventType"
  • "goog.net.streams.StreamParser"
  • "goog.crypt.base64"
  • "goog.events"
  • "goog.string"
  • "goog.asserts"

@Arxcis Arxcis marked this pull request as draft October 16, 2020 13:00
@Arxcis Arxcis changed the title Experimental / javascript es modules conversion Experimental / javascript ES modules conversion Oct 16, 2020
@Arxcis Arxcis changed the title Experimental / javascript ES modules conversion Experimental / Exploring javascript ES modules conversion Oct 16, 2020
@Arxcis Arxcis changed the title Experimental / Exploring javascript ES modules conversion Exploring javascript ES modules conversion Oct 16, 2020
@Arxcis Arxcis changed the title Exploring javascript ES modules conversion Exploring javascript ES modules (esm) conversion Oct 16, 2020
@Arxcis Arxcis changed the title Exploring javascript ES modules (esm) conversion Exploring javascript ES modules conversion Oct 16, 2020
@Arxcis Arxcis changed the title Exploring javascript ES modules conversion Exploring ES modules support Oct 16, 2020
@Arxcis Arxcis mentioned this pull request Oct 16, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Arxcis