Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix npe issue https://github.com/ArthurHub/Android-Image-Cropper/issues/551 #645

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

donfuxx
Copy link
Contributor

@donfuxx donfuxx commented Jan 22, 2019

see related issues #551 #616

Caused by java.lang.NullPointerException: Attempt to invoke virtual method 'android.os.Parcelable android.os.Bundle.getParcelable(java.lang.String)' on a null object reference
at com.theartofdev.edmodo.cropper.CropImageActivity.onCreate(CropImageActivity.java:63)

Fix by finishing the CropImageActivity gracefully (which gives the user the opportunity to try selecting an image again) instead of app crash.

Caused by java.lang.NullPointerException: Attempt to invoke virtual method 'android.os.Parcelable android.os.Bundle.getParcelable(java.lang.String)' on a null object reference
at com.theartofdev.edmodo.cropper.CropImageActivity.onCreate(CropImageActivity.java:63)
@tomerpetel
Copy link

@donfuxx when it is planned to merge it? I see it's still open...

@donfuxx
Copy link
Contributor Author

donfuxx commented Aug 4, 2019

Hi @tomerpetel ! Unfortunately I don't have write access to this repository. It's up to @ArthurHub to review and merge this ;-)

@tomerpetel
Copy link

Thx @donfuxx, @ArthurHub is it possible to review this fix and merge if passed?

@mirono
Copy link

mirono commented Oct 8, 2020

@tomerpetel It doesn't look that @ArthurHub is actively maintaining this. You may need to clone the repo and apply the PR fix in your cloned code.
Or maybe choose another image cropper?

@manuelrego27
Copy link

@mirono do you have any suggestions for another cropper? (lol)

@mirono
Copy link

mirono commented Nov 10, 2020

@manuelrego27 Never tried it myself but https://github.com/Yalantis/uCrop looks promising.
At least it is actively maintained.

@Canato
Copy link

Canato commented Nov 27, 2020

Hey!

I start a new project to handover this library
https://github.com/CanHub/Android-Image-Cropper

The ideia is that we keep improving because this project don't have updates since 2018
Hope I can count with your help.

Open to contribute, next pieces of work will be Android 11 permissions, refactor into Kotlin and ActivityContract

@mirono
Copy link

mirono commented Nov 27, 2020

I will be happy to help.

@manuelrego27
Copy link

holy shit, thank you @Canato !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants