-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix npe issue https://github.com/ArthurHub/Android-Image-Cropper/issues/551 #645
base: master
Are you sure you want to change the base?
Conversation
Caused by java.lang.NullPointerException: Attempt to invoke virtual method 'android.os.Parcelable android.os.Bundle.getParcelable(java.lang.String)' on a null object reference at com.theartofdev.edmodo.cropper.CropImageActivity.onCreate(CropImageActivity.java:63)
@donfuxx when it is planned to merge it? I see it's still open... |
Hi @tomerpetel ! Unfortunately I don't have write access to this repository. It's up to @ArthurHub to review and merge this ;-) |
Thx @donfuxx, @ArthurHub is it possible to review this fix and merge if passed? |
@tomerpetel It doesn't look that @ArthurHub is actively maintaining this. You may need to clone the repo and apply the PR fix in your cloned code. |
@mirono do you have any suggestions for another cropper? (lol) |
@manuelrego27 Never tried it myself but https://github.com/Yalantis/uCrop looks promising. |
Hey! I start a new project to handover this library The ideia is that we keep improving because this project don't have updates since Open to contribute, next pieces of work will be Android 11 permissions, refactor into Kotlin and ActivityContract |
I will be happy to help. |
holy shit, thank you @Canato !!! |
see related issues #551 #616
Fix by finishing the CropImageActivity gracefully (which gives the user the opportunity to try selecting an image again) instead of app crash.