Skip to content

Commit

Permalink
add combine partial to protobuf.
Browse files Browse the repository at this point in the history
  • Loading branch information
Jackson Newhouse authored and mwylde committed Jul 23, 2024
1 parent 88613ad commit bb69311
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 3 deletions.
1 change: 1 addition & 0 deletions datafusion/proto/proto/datafusion.proto
Original file line number Diff line number Diff line change
Expand Up @@ -1091,6 +1091,7 @@ enum AggregateMode {
FINAL_PARTITIONED = 2;
SINGLE = 3;
SINGLE_PARTITIONED = 4;
COMBINE_PARTIAL = 5;
}

message PartiallySortedInputOrderMode {
Expand Down
3 changes: 3 additions & 0 deletions datafusion/proto/src/generated/pbjson.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions datafusion/proto/src/generated/prost.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 4 additions & 3 deletions datafusion/proto/src/physical_plan/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -388,6 +388,9 @@ impl AsExecutionPlan for protobuf::PhysicalPlanNode {
protobuf::AggregateMode::SinglePartitioned => {
AggregateMode::SinglePartitioned
}
protobuf::AggregateMode::CombinePartial => {
AggregateMode::CombinePartial
}
};

let num_expr = hash_agg.group_expr.len();
Expand Down Expand Up @@ -1469,10 +1472,8 @@ impl AsExecutionPlan for protobuf::PhysicalPlanNode {
AggregateMode::Single => protobuf::AggregateMode::Single,
AggregateMode::SinglePartitioned => {
protobuf::AggregateMode::SinglePartitioned
},
AggregateMode::CombinePartial => {
unimplemented!()
}
AggregateMode::CombinePartial => protobuf::AggregateMode::CombinePartial,
};

let input_schema = exec.input_schema();
Expand Down

0 comments on commit bb69311

Please sign in to comment.