Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter by Contact Group #185

Merged
merged 5 commits into from
Jul 18, 2024
Merged

Filter by Contact Group #185

merged 5 commits into from
Jul 18, 2024

Conversation

rizlas
Copy link
Contributor

@rizlas rizlas commented Jul 16, 2024

Hi,
I've added the ability to filter contacts by group in all forms that utilize contact information. This enhancement will simplify the identification process, especially when dealing with multiple contacts sharing the same name but belonging to different groups.

Here's an image illustrating the current situation:

immagine

And here's an image showing the new filter by group feature:

immagine

This "problem" is not solved in bulk import and in case of multiple contact with same name this error will be raised:

Screenshot from 2024-07-16 22-14-07

Thank you for your plugin, at GARR (Italy nren) we are using it a lot 😃

Copy link
Member

@matejv matejv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

especially when dealing with multiple contacts sharing the same name but belonging to different groups

Huh. We don't use contacts much. I wasn't even aware there can be multiple contacts with the same name. I'll have to keep this in mind going forward.

Since you seem to be using contacts more extensively: see #162 and let us know if you have anything to add to discussion.

This "problem" is not solved in bulk import and in case of multiple contact with same name this error will be raised:

I see. I'll try to solve this separately at a later date.

Thank you for your plugin, at GARR (Italy nren) we are using it a lot 😃

From one NREN to another: Glad to hear you find it useful :)


I've requested a couple small changes. Let me know if you have any trouble and I can do the changes later.

netbox_inventory/forms/models.py Outdated Show resolved Hide resolved
netbox_inventory/forms/filters.py Outdated Show resolved Hide resolved
netbox_inventory/forms/filters.py Outdated Show resolved Hide resolved
@rizlas
Copy link
Contributor Author

rizlas commented Jul 17, 2024

Should be all fixed!

@matejv matejv merged commit e6050c1 into ArnesSI:master Jul 18, 2024
@matejv
Copy link
Member

matejv commented Jul 18, 2024

thank you

@rizlas
Copy link
Contributor Author

rizlas commented Sep 18, 2024

Hi, when this PR will be available in a release like 2.0.3?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants