Fix: Remove fibers so it can be built with node 16+ #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure the PR fulfills these requirements:
When resolving a specific issue, make sure it's referenced in the PR's title (e.g.
Closes #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes: A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)
If this PR introduce a breaking change, please describe the impact and migration path for existing applications
What kind of change does this PR introduce?
Remove node-fibers, so this project can be built with Node 16+.
More information:
According to node-fibers's readme, that project is obsolete, and will not work on Node 16+.
Since
fibersis an optional dependency, it can be safely removed. The performance will be dropped, but at least you can keep using the latest LTS version of Node.js now.