Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sessions feature #5158

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

feat: sessions feature #5158

wants to merge 11 commits into from

Conversation

RogerHYang
Copy link
Contributor

No description provided.

@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Oct 22, 2024
@RogerHYang RogerHYang added feature branch a feature branch that consolidates multiple features into a single commit on main DO NOT MERGE labels Oct 22, 2024
Copy link
Contributor

@Parker-Stafford Parker-Stafford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocking feature branch

@RogerHYang RogerHYang force-pushed the sessions2 branch 4 times, most recently from aee3252 to 0bbd3f5 Compare October 25, 2024 17:13
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Oct 28, 2024
@Arize-ai Arize-ai deleted a comment from review-notebook-app bot Oct 28, 2024
@RogerHYang RogerHYang force-pushed the sessions2 branch 3 times, most recently from bf6c625 to 4537967 Compare October 31, 2024 18:19
@RogerHYang RogerHYang force-pushed the sessions2 branch 2 times, most recently from f86ab63 to d36a5f1 Compare November 7, 2024 23:12
@RogerHYang RogerHYang force-pushed the sessions2 branch 2 times, most recently from 38eaee4 to 2706d0f Compare November 13, 2024 19:16
RogerHYang and others added 11 commits November 18, 2024 06:43
* feat(sesions): add session details page

* remove unused import, add error boundary

* pull user from root span
* feat(sessions): add trace latency p50 to session details

* fix type for latency in ui

* update test, fix where clause

* add is not none check for db filter

* revert latency dataloader changes

* revert dataloader changes for project span and trace latency

* refactor to use its own data loader

* remove extra param from test

* add unit tests

* ruff

* fix import

* fix name filter in other dataloader tests

* update unit test fixture naming, add unit test for project session graphql trace_latency_ms_quantile field

* clean up imports

* pin aiohttp

* fix unit test deps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE feature branch a feature branch that consolidates multiple features into a single commit on main size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
Status: 🔍. Needs Review
Development

Successfully merging this pull request may close these issues.

2 participants