Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_HAL_ChibiOS: Added support for ZeroOne_Air flight controller #29022

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

ZeroOne-Aero
Copy link
Contributor

AP_HAL_ChibiOS: Added support for our new ZeroOne_Air flight controller

Copy link
Collaborator

@andyp1per andyp1per left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

# PI10 EXT1_CS CS

# PWM output pins
PI0 TIM5_CH4 TIM5 PWM(1) GPIO(50)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider:

PI0  TIM5_CH4 TIM5 PWM(1) GPIO(50) BIDIR
PH12 TIM5_CH3 TIM5 PWM(2) GPIO(51)
PH11 TIM5_CH2 TIM5 PWM(3) GPIO(52) BIDIR
PH10 TIM5_CH1 TIM5 PWM(4) GPIO(53)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I get it now, thanks!

@peterbarker
Copy link
Contributor

Commit list needs cleaning up before merge.

@ZeroOne-Aero ZeroOne-Aero requested a review from andyp1per January 9, 2025 08:36
@ZeroOne-Aero
Copy link
Contributor Author

We've changed the content, please help us review it again, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants