AP_Mount: Topotek pitch rate direction fix #29002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the direction of pitch rate control in the Topotek gimbal driver (angle control is fine).
This bug has existed since the driver was first created in PR #27053 but we somehow missed it during testing. If you look closely the bug is fairly obvious from inspection because we can see the angle control includes the minus while the rate control does not.
This has been tested on real hardware and was discovered during testing of the new Mission Planner Gimbal Control interface (see ArduPilot/MissionPlanner#3386)